Uploaded image for project: 'bgpcep'
  1. bgpcep
  2. BGPCEP-1016

Do not use BindingReflections.findQName() for AFI/SAFI

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Medium
    • Resolution: Done
    • None
    • 0.20.0
    • BGP, BMP

    Description

      We have following hits on BindingReflections use:

      ./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/AbstractRIBSupport.java:172:            BindingReflections.findQName(afiClass.implementedInterface()),

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/AbstractRIBSupport.java:173:            BindingReflections.findQName(safiClass.implementedInterface())));

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:58:            BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:59:            BindingReflections.findQName(safi.implementedInterface())));

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:73:            BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:74:            BindingReflections.findQName(safi.implementedInterface())));   ./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:43:            BMP_AFI_QNAME, BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:44:            BMP_SAFI_QNAME, BindingReflections.findQName(safi.implementedInterface())));

./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:60:            afiQname, BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:61:            safiQname, BindingReflections.findQName(safi.implementedInterface())));

      As we are moving away from using reflection, migrate these call sites to use mdsal-binding-dom-codec's IdentityCodec to translate these.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. MDSAL-781 Eliminate BindingReflections

          • Medium - Has the potential to affect progress.
          • Confirmed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              rovarga Robert Varga
              rovarga Robert Varga
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: