Details
-
Task
-
Status: Resolved
-
Medium
-
Resolution: Done
-
None
Description
We have following hits on BindingReflections use:
./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/AbstractRIBSupport.java:172: BindingReflections.findQName(afiClass.implementedInterface()), ./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/AbstractRIBSupport.java:173: BindingReflections.findQName(safiClass.implementedInterface()))); ./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:58: BindingReflections.findQName(afi.implementedInterface()), ./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:59: BindingReflections.findQName(safi.implementedInterface()))); ./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:73: BindingReflections.findQName(afi.implementedInterface()), ./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:74: BindingReflections.findQName(safi.implementedInterface()))); ./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:43: BMP_AFI_QNAME, BindingReflections.findQName(afi.implementedInterface()), ./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:44: BMP_SAFI_QNAME, BindingReflections.findQName(safi.implementedInterface()))); ./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:60: afiQname, BindingReflections.findQName(afi.implementedInterface()), ./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:61: safiQname, BindingReflections.findQName(safi.implementedInterface())));
As we are moving away from using reflection, migrate these call sites to use mdsal-binding-dom-codec's IdentityCodec to translate these.
Attachments
Issue Links
- blocks
-
MDSAL-781 Eliminate BindingReflections
-
- Confirmed
-
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 106627,1 | Use BindingReflections.getQName() | master | bgpcep | Status: MERGED | +2 | +1 |
| 106628,2 | Do not use BindingReflections in AbstractRIBSupport | master | bgpcep | Status: MERGED | +2 | +1 |
| 106630,1 | Do not use BindingReflections in bmp-impl | master | bgpcep | Status: MERGED | +2 | +1 |
| 106633,4 | Clean up RibSupport registration | master | bgpcep | Status: MERGED | +2 | +1 |
| 106640,3 | Move RibSupportUtils | master | bgpcep | Status: MERGED | +2 | +1 |
| 106644,1 | Do not use BindingReflections in AbstractRIBSupportTest | master | bgpcep | Status: MERGED | +2 | +1 |
| 106645,2 | Hide RibSupportUtils | master | bgpcep | Status: MERGED | +2 | +1 |
| 106649,2 | Do not use RibSupportUtils in AdjRibInWriter | master | bgpcep | Status: MERGED | +2 | +1 |
| 106653,1 | Do not use RibSupportUtils in AdjRibOutListener | master | bgpcep | Status: MERGED | +2 | +1 |
| 106654,1 | Do not use RibSupportUtils in PeerTest | master | bgpcep | Status: MERGED | +2 | +1 |
| 106655,2 | Do not use RibSupportUtils in SynchronizationAndExceptionTest | master | bgpcep | Status: MERGED | +2 | +1 |
| 106657,2 | Remove RibSupportUtils | master | bgpcep | Status: MERGED | +2 | +1 |