Uploaded image for project: 'bgpcep'
  1. bgpcep
  2. BGPCEP-1027

Do not use RpcService in BGPCEP components

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Medium
    • Resolution: Done
    • None
    • 0.20.5
    • None

    Description

      A quick grep shows at least these users of deprecated API:

      ./bgpcep/algo/algo-impl/src/main/java/org/opendaylight/algo/impl/PathComputationServer.java:        registration = rpcService.registerRpcImplementation(PathComputationService.class, this);
      ./bgpcep/bgp/benchmark-app/src/main/java/org/opendaylight/protocol/bgp/benchmark/app/AppPeerBenchmark.java:        rpcRegistration = rpcProviderRegistry.registerRpcImplementation(OdlBgpAppPeerBenchmarkService.class, this);
      ./bgpcep/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java:                rpcRegistration = rpcRegistry.registerRpcImplementation(BgpPeerRpcService.class,
      ./bgpcep/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/PCEPTopologyProvider.java:        elementReg = rpcRegistry.registerRpcImplementation(NetworkTopologyPcepService.class,
      ./bgpcep/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/PCEPTopologyProvider.java:        networkReg = rpcRegistry.registerRpcImplementation(NetworkTopologyPcepProgrammingService.class,
      ./bgpcep/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/PCEPTopologyTracker.java:        statsReg = rpcProviderRegistry.registerRpcImplementation(PcepTopologyStatsRpcService.class, statsRpcs);
      ./bgpcep/pcep/tunnel/tunnel-provider/src/main/java/org/opendaylight/bgpcep/pcep/tunnel/provider/PCEPTunnelClusterSingletonService.java:                .registerRpcImplementation(TopologyTunnelPcepProgrammingService.class, tp, Set.of(topology));
      ./bgpcep/programming/impl/src/main/java/org/opendaylight/bgpcep/programming/impl/ProgrammingServiceImpl.java:        reg = rpcProviderRegistry.registerRpcImplementation(ProgrammingService.class, this);
      

      Convert them to new-style yang.binding.Rpc-based implementations.

      Attachments

        Issue Links

          # Subject Branch Project Status CR V

          Activity

            People

              cicut Ľuboš Čičut
              rovarga Robert Varga
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: