Autonomous system number ignored when BGP speaker connects to ODL

After a BGP speaker connects to ODL, it can state anything as its Autonomous System number in its and ODL will happily ignore that and proceed to accept the speaker, storing the updates in whatever RIB instance it was registered with.

However when ODL connects to a BGP speaker and the Autonomous System number stated by the speaker's Open message does not match the Autonomous System number as stored in the BGP peer registry, the BGP speaker will receive a NOTIFICATION stating that and then the connection is closed.

The BGP peer in question was configured as "ibgp" (or "Ibgp" - it seems the system can't agree on the name of this enum value, see CONTROLLER-1280), which means the latter behavior is correct. Additionally as a peer-to-peer protocol, the behavior between two peers shall not depend on who connected to whom.