Uploaded image for project: 'bgpcep'
  1. bgpcep
  2. BGPCEP-472

Injecting route with missing next-hop value causes exception in reachability topology builder

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • Bugzilla Migration
    • Bugzilla Migration
    • BGP
    • None
    • Operating System: All
      Platform: All

    • 6001

    Description

      Next-hop is a well-known mandatory attribute and should be present when injecting IPv4/v6 unicast routes. However bad input where the value is missing causes exception to be thrown while updating IPv4/v6 reachability topology

      NPE is thrown in else block of AbstractReachabilityTopologyBuilder#advertizingNode when nh is null

      private NodeId advertizingNode(final Attributes attrs) {
      final CNextHop nh = attrs.getCNextHop();
      if (nh instanceof Ipv4NextHopCase)

      { final Ipv4NextHop ipv4 = ((Ipv4NextHopCase) nh).getIpv4NextHop(); return new NodeId(ipv4.getGlobal().getValue()); }

      else if (nh instanceof Ipv6NextHopCase)

      { final Ipv6NextHop ipv6 = ((Ipv6NextHopCase) nh).getIpv6NextHop(); return new NodeId(ipv6.getGlobal().getValue()); }

      else {
      LOG.warn("Unhandled next hop class {}", nh.getImplementedInterface());
      return null;
      }
      }

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ajayl.bro@gmail.com Ajay L
            ajayl.bro@gmail.com Ajay L
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: