Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-159

Flow statistics model do not have a notion of a multi-part transaction

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Resolution: Done
    • None
    • None
    • mdsal
    • None
    • Operating System: All
      Platform: All

    Description

      The way the various statistics notifications are modeled is that they each define a moreReplies leaf:

      notification flows-statistics-update {
      description "Flows statistics sent by switch";
      leaf moreReplies

      { type boolean; }

      uses inv:node;
      uses flow-and-statistics-map-list;
      uses tr:transaction-aware;
      }

      now this makes it quite clunky in the stats manager code, where each instantiation needs to pass that one bit down. Correct way of doing this would be to introduce a multipart-transaction-aware concepts:

      grouping multipart-transaction-aware {
      uses tr:transaction-aware;
      leaf moreReplies

      { type boolean; default false; }

      }

      and use that in the stats, like this:

      notification flows-statistics-update

      { description "Flows statistics sent by switch"; uses inv:node; uses flow-and-statistics-map-list; uses tr:multipart-transaction-aware; }

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            rovarga Robert Varga
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: