Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-1834

Transaction Trace tool wiring for ping-pong DataBroker is wrong

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Medium
    • Resolution: Done
    • None
    • Fluorine, Oxygen SR3
    • None
    • None

    Description

      while working on CONTROLLER-1831 and reviewing blueprint wiring XML in controller, I realized that opendaylight/md-sal/mdsal-trace/binding-impl/src/main/resources/org/opendaylight/blueprint/impl-blueprint.xml contained a subtle mistake:

      The tracing pingpong DataBroker was, by mistake, wired to the original non-tracing 
      DOMDataBroker instead of the TracingDOMDataBroker. The tracing non pingpong DataBroker was already correct. This means that trace:transaction missed any leaks caused by non-closed transactions from users of the pingpong DataBroker.

      Having some application code use the tracing and other the non-tracing original DB, including separate classloading due to the BindingNormalizedNodeCodecRegistry in the BindingToNormalizedNodeCodec, when the Transaction Trace tool is installed (only), smells like asking for trouble... in fact, I'm wondering if perhaps this could be causing MDSAL-213 !?

      I'll raise a Gerrit with a proposed fix for this ASAP.

      See also CONTROLLER-1832.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              vorburger Michael Vorburger
              vorburger Michael Vorburger
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: