Description
A quick grep shows at least these users of deprecated API:
./controller/benchmark/dsbenchmark/src/main/java/org/opendaylight/dsbenchmark/DsbenchmarkProvider.java: rpcReg = rpcService.registerRpcImplementation(DsbenchmarkService.class, this); ./controller/benchmark/ntfbenchmark/src/main/java/ntfbenchmark/impl/NtfbenchmarkProvider.java: reg = rpcService.registerRpcImplementation(NtfbenchmarkService.class, this); ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/GlobalBindingRTCServer.java: reg = rpcProvider.registerRpcImplementation(RpcbenchPayloadService.class, this); ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/RoutedBindingRTCServer.java: reg = rpcProvider.registerRpcImplementation(RpcbenchPayloadService.class, this, paths); ./controller/benchmark/rpcbenchmark/src/main/java/rpcbenchmark/impl/RpcbenchmarkProvider.java: reg = providerRegistry.registerRpcImplementation(RpcbenchmarkService.class, this); ./controller/opendaylight/md-sal/eos-dom-akka/src/main/java/org/opendaylight/controller/eos/akka/AkkaEntityOwnershipService.java: reg = rpcProvider.registerRpcImplementation(OdlEntityOwnersService.class, this); ./controller/opendaylight/md-sal/sal-cluster-admin-impl/src/main/java/org/opendaylight/controller/cluster/datastore/admin/OSGiClusterAdmin.java: reg = rpcProviderService.registerRpcImplementation(ClusterAdminService.class, ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java: doReturn(newReg).when(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java: doReturn(oldReg).when(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java: inOrder.verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java: inOrder.verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/sal-remoterpc-connector/src/test/java/org/opendaylight/controller/remote/rpc/OpsRegistrarTest.java: verify(rpcService).registerRpcImplementation(any(RemoteRpcImplementation.class), ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/BasicRpcTestProvider.java: rpcRegistration = rpcProviderRegistry.registerRpcImplementation(BasicRpcTestService.class, this); ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/CarProvider.java: regs.add(rpcProviderService.registerRpcImplementation(CarService.class, this)); ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/MdsalLowLevelTestProvider.java: registration = rpcRegistry.registerRpcImplementation(OdlMdsalLowlevelControlService.class, this); ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/PeopleProvider.java: regs.add(rpcProviderService.registerRpcImplementation(CarPurchaseService.class, rpcImplementation, ./controller/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/PeopleProvider.java: regs.add(rpcProviderService.registerRpcImplementation(CarPurchaseService.class, rpcImplementation)); ./controller/opendaylight/md-sal/samples/toaster-provider/src/main/java/org/opendaylight/controller/sample/toaster/provider/OpendaylightToaster.java: reg = rpcProviderService.registerRpcImplementation(ToasterService.class, this);
Convert them to yang.binding.Rpc-based implementations.
Attachments
Issue Links
- blocks
-
MDSAL-772 Remove RpcService
-
- Resolved
-
- split to
-
CONTROLLER-2090 Remove support for RPCs/Actions/Notifications
-
- Resolved
-
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 108003,1 | [WIP]Do not use RpcService in Controller components | master | controller | Status: ABANDONED | 0 | -1 |
| 108004,3 | Do not use RpcService in dsbenchmark | master | controller | Status: MERGED | +2 | +1 |
| 108005,3 | Do not use RpcService in ntfbenchmark | master | controller | Status: MERGED | +2 | +1 |
| 108006,5 | Do not use RpcService in rpcbenchmark | master | controller | Status: MERGED | +2 | +1 |
| 108007,7 | Do not use RpcService in eos-dom-akka | master | controller | Status: MERGED | +2 | +1 |
| 108011,11 | Do not use RpcService in sal-cluster-admin-impl | master | controller | Status: MERGED | +2 | +1 |
| 108015,8 | Do not use RpcService in sal-cluster-admin-karaf-cli | master | controller | Status: MERGED | +2 | +1 |
| 108017,7 | Do not use RpcService in karaf-cli | master | controller | Status: MERGED | +2 | +1 |
| 108019,15 | Do not use RpcService in provider | master | controller | Status: MERGED | +2 | +1 |
| 108020,12 | Do not use RpcService in toaster-consumer | master | controller | Status: MERGED | +2 | +1 |
| 108021,5 | Do not use RpcService in toaster-it | master | controller | Status: ABANDONED | 0 | -1 |
| 108022,13 | Do not use RpcService in toaster-provider | master | controller | Status: MERGED | +2 | +1 |
| 108023,15 | Do not use RpcService in sal-binding-it | master | controller | Status: MERGED | +2 | +1 |
| 108024,8 | [WIP]Do not use RpcService in blueprint | master | controller | Status: ABANDONED | 0 | 0 |