Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-336

SimpleForwardingImpl hits NPE when .frm member is null and new host is discovered

    XMLWordPrintable

Details

    • 773
    • Low

    Description

      <flaviof> hi folks. I'm trying latest integration build, and hit an exception: https://gist.github.com/eba571a29abeaad5b914
      <flaviof> looking at the trace: 2014-04-17 18:29:50.840 EDT [Thread-22] ERROR o.o.c.h.internal.HostTracker - Exception on new host notification
      <flaviof> java.lang.NullPointerException: null
      <flaviof> at org.opendaylight.controller.samples.simpleforwarding.internal.SimpleForwardingImpl.installPerHostRules(SimpleForwardingImpl.java:653) ~[na:na]
      <flaviof> at org.opendaylight.controller.samples.simpleforwarding.internal.SimpleForwardingImpl.notifyHTClient(SimpleForwardingImpl.java:840) ~[na:na]
      <flaviof> at org.opendaylight.controller.hosttracker.internal.HostTracker.notifyHostLearnedOrRemoved(HostTracker.java:568) [bundlefile:na]
      <flaviof> at org.opendaylight.controller.hosttracker.internal.HostTracker.access$600(HostTracker.java:103) [bundlefile:na]
      <flaviof> at org.opendaylight.controller.hosttracker.internal.HostTracker$NotifyHostThread.run(HostTracker.java:536) [bundlefile:na]
      <flaviof> is it reasonable to assume that the 'frm' attribute in the SimpleForwardingImpl object can be null?
      <flaviof> Madhu: this looks like code you wrote back in Mar/13... any ideas?
      <aboch> flaviof: since the dependency on frm is not strict (you can see it in simple forwarding Activator), yes, there can be a time window when SF is brought up until frm comes up, during which frm reference is null
      <flaviof> interesting. I see: https://www.dropbox.com/s/288q5amswsjhgm8/Screenshot%202014-04-17%2018.51.41.png
      <flaviof> thanks Alessandro
      <aboch> I am not sure though why SF dependencies on frm and ht were not made strict
      <aboch> I think they should be
      <aboch> np
      <flaviof> is this something worth pursuing at all?
      <flaviof> I'm not familiar on the things are worth documenting/fixing. specially on the simpleFwd code
      <aboch> SF is in samples, sample apps. It installs (*, /32) entries for reaching the newly discovered hosts.
      <aboch> It allows a mininet pingall to work out of the box
      <flaviof> gotcha.
      <aboch> feel free to propose a patch
      <flaviof> all right!
      <flaviof> Seems simple enough. I will give it a try.
      <flaviof> aboch: should start by opening a bug in bugzilla and assign it to me?
      <aboch> yeah
      <flaviof> aboch: will do
      <aboch> and thanks
      <flaviof> aboch: np!

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            flavio@flaviof.com Flavio Fernandes
            flavio@flaviof.com Flavio Fernandes
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: