Details
-
Bug
-
Status: Resolved
-
Resolution: Duplicate
-
None
-
None
-
None
-
Operating System: Mac OS
Platform: PC
-
1246
Description
looked closely at the Abstract<projectname>ProviderModule auto-generated code and noticed a couple of small things.
if (dataBroker!=null)
{ dataBrokerDependency = dependencyResolver.resolveInstance(org.opendaylight.controller.sal.binding.api.data.DataProviderService.class, dataBroker, dataBrokerJmxAttribute);; <=== double semi-colon }if(oldInstance!=null && canReuseInstance(oldModule))
{ <=== Is this a missing else or just an indentation problem ? instance = reuseInstance(oldInstance); }else {
And there is an unnecessary semi-colon here
;this.oldModule=null;
Maybe the auto-generated files should go through appropriate tooling to detect these things.
Attachments
Issue Links
- duplicates
-
CONTROLLER-585 Config code generator produces code that has small syntax problems
- Resolved