Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-583

Problems with AbstractProviderModule Auto-generated Code

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Duplicate
    • None
    • None
    • config
    • None
    • Operating System: Mac OS
      Platform: PC

    • 1246

    Description

      looked closely at the Abstract<projectname>ProviderModule auto-generated code and noticed a couple of small things.

      if (dataBroker!=null)

      { dataBrokerDependency = dependencyResolver.resolveInstance(org.opendaylight.controller.sal.binding.api.data.DataProviderService.class, dataBroker, dataBrokerJmxAttribute);; <=== double semi-colon }

      if(oldInstance!=null && canReuseInstance(oldModule))

      { <=== Is this a missing else or just an indentation problem ? instance = reuseInstance(oldInstance); }

      else {

      And there is an unnecessary semi-colon here

      ;this.oldModule=null;

      Maybe the auto-generated files should go through appropriate tooling to detect these things.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Unassigned Unassigned
              repenno Reinaldo Penno
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: