Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-587

Heisenbug in DataNormalizerTest

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • None
    • None
    • mdsal
    • None
    • Operating System: Mac OS
      Platform: Macintosh

    • 1256

    Description

      On MacOS 10.9.3 (verified on 3 machines) with Java 1.7, the DataNormalizerTest fails because the comparator provided in verifyLegacyNode() does not actually provide a total ordering of the childData and childNodes.

      It appears as though Windows and Linux are immune.

      This results in a build failure for sal-common-impl that looks like this:

      -------------------------------------------------------
      T E S T S
      -------------------------------------------------------
      Running org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest
      SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      SLF4J: Defaulting to no-operation (NOP) logger implementation
      SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.892 sec <<< FAILURE! - in org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest
      testToLegacyNormalizedNode(org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest) Time elapsed: 0.068 sec <<< FAILURE!
      java.lang.AssertionError: Child node QName expected:<(urn:opendaylight:params:xml:ns:yang:controller:md:sal:normalization:test?revision=2014-03-13)inner-list> but was:<(urn:opendaylight:params:xml:ns:yang:controller:md:sal:normalization:test?revision=2014-03-13)id>
      at org.junit.Assert.fail(Assert.java:91)
      at org.junit.Assert.failNotEquals(Assert.java:645)
      at org.junit.Assert.assertEquals(Assert.java:126)
      at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest.verifyLegacyNode(DataNormalizerTest.java:437)
      at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest.verifyLegacyNode(DataNormalizerTest.java:441)
      at org.opendaylight.controller.md.sal.common.impl.util.compat.DataNormalizerTest.testToLegacyNormalizedNode(DataNormalizerTest.java:245)

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            colindixon Colin Dixon
            colindixon Colin Dixon
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: