Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-649

Performance: BindingToNormalizedNodeCodec must not use intermediate representation

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • Helium
    • None
    • mdsal
    • None
    • Operating System: All
      Platform: All

    • 1425

    Description

      As evidenced here:

      public Entry<org.opendaylight.yangtools.yang.data.api.InstanceIdentifier, NormalizedNode<?, ?>> toNormalizedNode(
      final Entry<org.opendaylight.yangtools.yang.binding.InstanceIdentifier<? extends DataObject>, DataObject> binding) {
      Entry<org.opendaylight.yangtools.yang.data.api.InstanceIdentifier, CompositeNode> legacyEntry = bindingToLegacy
      .toDataDom(binding);
      Entry<org.opendaylight.yangtools.yang.data.api.InstanceIdentifier, NormalizedNode<?, ?>> normalizedEntry = legacyToNormalized
      .toNormalized(legacyEntry);
      LOG.trace("Serialization of {}, Legacy Representation: {}, Normalized Representation: {}", binding,
      legacyEntry, normalizedEntry);
      if (isAugmentation(binding.getKey().getTargetType())) {

      the translation uses intermediate representation in CompositeNode, since this is performance-critical path, this has to be avoided.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            rovarga Robert Varga
            rovarga Robert Varga
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: