Uploaded image for project: 'controller'
  1. controller
  2. CONTROLLER-690

ConfigPusherImpl.java - Unnecessary Synchronization

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Resolution: Won't Do
    • Helium
    • None
    • config
    • None
    • Operating System: Mac OS
      Platform: PC

    Description

      The opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusherImpl.java performs method level synchronization on a couple of methods which could possibly end up waiting for a long period of time.

      In general you do NOT want to perform synchronization of blocks of code which could possibly take a long time to run as it will just back everything up.

      See Gerrit 9844 for some inline comments.

      This bug should be used to asses if synchronization is really necessary on the methods provided, and if it it then it should be optimized.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Unassigned Unassigned
              devin.avery@brocade.com Devin Avery
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: