Uploaded image for project: 'genius'
  1. genius
  2. GENIUS-172

IdManager createIdPool should never return false positive Failure, causing wrong "Failed to create idPool for InterfaceMgr" error log but not diagstatus failure

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Medium Medium
    • Neon
    • None
    • None
    • None

      https://git.opendaylight.org/gerrit/#/c/72782/10/interfacemanager/interfacemanager-impl/src/main/java/org/opendaylight/genius/interfacemanager/InterfacemgrProvider.java@186 claims that IdManager createIdPool() "can fail on two nodes but isn't a failure as long as at least one node succeeds", and uses that as the justification why it's OK to LOG.error that as "Failed to create idPool for InterfaceMgr", but not ifmStatusProvider.reportStatus(e); it for GENIUS-108.

      If that is true, then IdManager createIdPool() really has a bug. It should never return a failure when actually the idPool was created successfully (on another node).

      When that is fixed, or if it is determined that it's actually fine, then InterfacemgrProvider should be made to ifmStatusProvider.reportStatus(e); in case it "Failed to create idPool for InterfaceMgr".

            ankit.ericsson Ankit Jain
            vorburger Michael Vorburger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: