Uploaded image for project: 'genius'
  1. genius
  2. GENIUS-237

Excessive toString() in EntityOwnershipUtils

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Medium Medium
    • Oxygen-SR4, Fluorine-SR2, Neon
    • Oxygen-SR3
    • None
    • None

      I'm looking at a Java Flight Recording obtained from (internal) scale lab testing, and see extensive "TLAB Allocations" due to what appears to be a clear mistake causing excessive toString() usage in EntityOwnershipUtils.runOnlyInOwnerNode():

      char[] java.util.Arrays.copyOf(char[], int)	939
      void java.lang.AbstractStringBuilder.ensureCapacityInternal(int)	939
      AbstractStringBuilder java.lang.AbstractStringBuilder.append(String)	880
      StringBuilder java.lang.StringBuilder.append(String)	880
      String org.opendaylight.mdsal.eos.common.api.GenericEntity.toString()	340
      void org.opendaylight.genius.utils.clustering.EntityOwnershipUtils.runOnlyInOwnerNode(String, String, JobCoordinator, String, Runnable)	340
      void org.opendaylight.genius.interfacemanager.listeners.InterfaceTopologyStateListener.runOnlyInOwnerNode(String, Runnable)	340
      void org.opendaylight.genius.interfacemanager.listeners.InterfaceTopologyStateListener.update(InstanceIdentifier, OvsdbBridgeAugmentation, OvsdbBridgeAugmentation)	340
      void org.opendaylight.genius.interfacemanager.listeners.InterfaceTopologyStateListener.update(InstanceIdentifier, DataObject, DataObject)	340
      void org.opendaylight.genius.datastoreutils.AsyncClusteredDataTreeChangeListenerBase$DataTreeChangeHandler.run()	340
      void java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor$Worker)	340
      void java.util.concurrent.ThreadPoolExecutor$Worker.run()	340
      void java.lang.Thread.run()	340

            vorburger Michael Vorburger
            vorburger Michael Vorburger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: