Uploaded image for project: 'genius'
  1. genius
  2. GENIUS-276

updateDpnTepInterfaceInfoToConfig doesn't update dpnTepsState correctly

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: High High
    • Neon
    • None
    • ITM
    • None
    • genius master

    • Highest

      Although updateDpnTepInterfaceInfoToConfig called ITMBatchingUtils.update to change dpnTepsState per srcDpnId, but ResourceBatchingManager will overwrite the old one with new one, new one doesn't contain the old one, this can be read out from source code.

      case ActionableResource.UPDATE:
      Object updated = actResource.getInstance();
      Object original = actResource.getOldInstance();
      resHandler.update(tx, dsType, actResource.getInstanceIdentifier(), original,
      updated,transactionObjects);
      break;

      Because we don't setOldInstance when call  ITMBatchingUtils.update. The actual test result has confirmed this.

      vagrant@odl:~/karaf-0.9.0-SNAPSHOT$ grep ", remoteDpn TunnelName " data/log/karaf.log
      2019-05-09T01:52:12,568 | INFO | jobcoordinator-main-task-2 | ItmInternalTunnelAddWorker | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | ofTunnelPortName of0383160132b, remoteDpn TunnelName tuna37285b5abf, dstDpnId 176824911782496
      2019-05-09T01:52:12,607 | INFO | jobcoordinator-main-task-2 | ItmInternalTunnelAddWorker | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | ofTunnelPortName of630c73993ed, remoteDpn TunnelName tund705cf3c875, dstDpnId 259598474342123
      2019-05-09T01:52:34,579 | INFO | jobcoordinator-main-task-2 | ItmInternalTunnelAddWorker | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | ofTunnelPortName ofc577a5608d6, remoteDpn TunnelName tun050445aeaad, dstDpnId 176824911782496
      2019-05-09T01:52:34,586 | INFO | jobcoordinator-main-task-2 | ItmInternalTunnelAddWorker | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | ofTunnelPortName of630c73993ed, remoteDpn TunnelName tunc0442208f5e, dstDpnId 44194128541826
      2019-05-09T01:52:34,589 | INFO | jobcoordinator-main-task-2 | ItmInternalTunnelAddWorker | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | ofTunnelPortName ofc577a5608d6, remoteDpn TunnelName tunda48ca3f373, dstDpnId 259598474342123
      2019-05-09T01:52:34,590 | INFO | jobcoordinator-main-task-2 | ItmInternalTunnelAddWorker | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | ofTunnelPortName of0383160132b, remoteDpn TunnelName tune929b964c6e, dstDpnId 44194128541826
      vagrant@odl:~/karaf-0.9.0-SNAPSHOT$ grep "addTunnelEndPointInfoToCache" data/log/karaf.log
      2019-05-09T01:52:13,165 | INFO | opendaylight-cluster-data-notification-dispatcher-46 | DpnTepStateCache | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | addTunnelEndPointInfoToCache: call added, tunnel tund705cf3c875, src dpn 176824911782496, dst dpn 259598474342123
      2019-05-09T01:52:35,101 | INFO | opendaylight-cluster-data-notification-dispatcher-69 | DpnTepStateCache | 267 - org.opendaylight.genius.itm-impl - 0.7.0.SNAPSHOT | addTunnelEndPointInfoToCache: call added, tunnel tune929b964c6e, src dpn 259598474342123, dst dpn 44194128541826
      vagrant@odl:~/karaf-0.9.0-SNAPSHOT$

            enidadh nidhi adhvaryu
            yangyi01 Yi Yang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: