Uploaded image for project: 'infrautils'
  1. infrautils
  2. INFRAUTILS-16

JobCoordinator enqueueJob must return a ListenableFuture instead of void

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Low
    • Resolution: Done
    • Oxygen
    • 1.9.0
    • General
    • None

    • Operating System: All
      Platform: All

    Description

      JobCoordinator enqueueJob must not return void but a (List of or single compound?) ListenableFuture, or a CompletionStage. This will let clients await completion of the submitted job, or at very least attach error logging, with context. (Client will ideally do this non-blocking through future chaining, not blocking get.)

      INFRAUTILS-8 is a related idea, but about capturing the stack trace, which is a separate idea - this issue here is only about returning a Future.

      Let us do this only in infrautils, and not in parallel in the duplicated code in infrautils as well as its origin in genius, because https://git.opendaylight.org/gerrit/#/c/60303/ is (hopefully) about to be finally merged.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. GENIUS-91 IdManager operations such as createIdPool and allocateIdRange should return a Future letting clients await finishing of the internal DataStoreJobCoordinator.enqueueJob() ?

          • High - Serious problem that could block progress.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. INFRAUTILS-8 JobCoordinator (ex-DataStoreJobCoordinator) job failures should indicate stack trace of original caller who submitted job

          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. OPNFLWPLUG-1051 Replace NodeConfigurator with infrautils JobCoordinator (from which it was originally forked)

          • Medium - Has the potential to affect progress.
          • Resolved
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              rovarga Robert Varga
              vorburger Michael Vorburger
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: