Details
-
Improvement
-
Status: Resolved
-
Medium
-
Resolution: Done
-
None
-
None
-
None
Description
GENIUS-237 hit an issue of apparent excessive toString(), and turns out to be due to be just because JobCoordinator's enqueueJob() requires a String key argument.
Looking into this see, we see that JobCoordinator's implementation doesn't actually really require a String - just a key for a Map (so that "Jobs with the same key are run sequentially. Jobs with different keys are run in parallel.")
Why don't we therefore change the JobCoordinator API & Impl so key can be any Object instead String - that way we can save caller any "artificial" (unnecessary) toString invocations.
Attachments
Issue Links
- blocks
-
GENIUS-237 Excessive toString() in EntityOwnershipUtils
-
- Resolved
-
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 77784,1 | JobCoordinator key Object instead String | master | infrautils | Status: ABANDONED | -1 | 0 |
| 92786,3 | Use plain Object in JobCoordinator.enqueueJob() | master | infrautils | Status: MERGED | +2 | +1 |