Uploaded image for project: 'l2switch'
  1. l2switch
  2. L2SWITCH-47

Incorrect broadcast/multicast check

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • unspecified
    • None
    • General
    • None

    • Operating System: All
      Platform: All

    • 3576

    Description

      ReactiveFlowWriter.java checks destination Macs for "ff:ff:ff:ff:ff:ff" only.

      This is incorrect - the check should be for all broadcast and multicast addresses as these should be flooded and no "flows" created for them.

      The correct check (cut-n-paste from the uml virtual switch source) expressed in C is:

      #define IS_BROADCAST(addr) ((addr[0] & 1) == 1)

      In other words - bit 1 in the first Mac address byte must be raised.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            aivanov@brocade.com Anton Ivanov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: