Details
-
Improvement
-
Status: Verified
-
Medium
-
Resolution: Done
-
None
-
None
-
None
Description
Having a @CheckReturnValue annotation always generated would make perfect sense IMHO, because we could then use that in static code analysis to ensure that all users of the RPC do check the Future RpcResult for errors - even if there is no Output.
The "@CheckReturnValue on YANG RPC generated interfaces extending RpcService" thread on https://lists.opendaylight.org/pipermail/mdsal-dev/2017-November/thread.html has the full background.
Attachments
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 65063,5 | MDSAL-294: Binding v1 generator - Add @CheckReturnValue on RPC methods | master | mdsal | Status: MERGED | +2 | +1 |
| 65379,1 | Fix broken build from FindBugs RV_RETURN_VALUE_IGNORED violation in RPC | master | genius | Status: MERGED | +2 | +1 |