Details
-
Improvement
-
Status: Resolved
-
Medium
-
Resolution: Done
-
None
-
None
Description
Current predicates do not quite work for complex queries. We have the makings of a DOMQueryPredicate.And in the fact that a query has a set of predicates and DOMQueryPredicate.Not, which is a negation.
Generalize these concepts to have proper algebra and combination of predicates. As Predicate.Not is showing such CompositePredicates do not have a path – hence we'll have two immediate subclasses of DOMQueryPredicate to distinguish these two.
It seems that we have to separate the combination of predicates with differing paths (lookup+match) and same paths (lookup + multiple matches). Target class hierarchy will be ... interesting, but should cover the algebra quite well.
Also update DOMQueryMatcher to handle these changes.
Attachments
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 88134,1 | Update Mdsal517Test a bit | master | mdsal | Status: MERGED | +2 | +1 |
| 88136,1 | Update Mdsal517Test a bit | 5.0.x | mdsal | Status: MERGED | +2 | +1 |
| 88145,1 | Update Mdsal517Test a bit | v4.0.x | mdsal | Status: MERGED | +2 | +1 |
| 93458,5 | Refactor DOMQueryPredicate | master | mdsal | Status: MERGED | +2 | +1 |
| 93543,1 | Refactor DOMQueryPredicate | 5.0.x | mdsal | Status: MERGED | +2 | +1 |
| 93544,1 | Refactor DOMQueryPredicate | 6.0.x | mdsal | Status: MERGED | +2 | +1 |