Details
-
Improvement
-
Status: Confirmed
-
Low
-
Resolution: Unresolved
-
None
Description
PingPongTransactionChain is a very complicated piece of machinery, which has only 21.5% coverage (and has the most uncovered lines of all of MD-SAL) because most of the time we are hitting happy paths.
We do not want to disturb its layout or implementation, but as Mockito has support for mocking final classes, we should be able to better control its testing, covering unhappy paths as well.
Attachments
Issue Links
- is blocked by
-
MDSAL-756 PingPongTransactionChain's cancel() always closes underlying chain
-
- Resolved
-
Gerrit Reviews
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 102843,13 | Increase PingPongTransactionChain coverage | master | mdsal | Status: NEW | -1 | +1 |
| 97953,3 | Add basic PingPongTransactionChainTest | master | mdsal | Status: MERGED | +2 | +1 |
| 100807,13 | Improve PingPongTransactionChain coverage | master | mdsal | Status: MERGED | +2 | +1 |
| 100862,5 | Create AbstractPingPongTransactionChain | master | mdsal | Status: MERGED | +2 | +1 |
| 101262,2 | Clean up SnapshotBackedRead(Write)TransactionTest | master | mdsal | Status: MERGED | +2 | +1 |
| 101263,2 | Add create/cancel/create test for PingPongTransactionChain | master | mdsal | Status: MERGED | +2 | +1 |
| 101264,1 | Add create/create test for PingPongTransactionChain | master | mdsal | Status: MERGED | +2 | +1 |