Uploaded image for project: 'netconf'
  1. netconf
  2. NETCONF-1150

Don't use NotificationListener in NETCONF components

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Medium
    • Resolution: Won't Do
    • None
    • None
    • None
    • None

    Description

      Usage of generated interfaces extending org.opendaylight.yangtools.yang.binding.NotificationListener interface was deprecated for removal via MDSAL-496.

      In order to eliminate dependency on deprecated interface the affected logic require update to use org.opendaylight.mdsal.binding.api.NotificationService.Listener instead.

      Affected components:

      ./netconf/plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/server/mdsal/notifications/CreateSubscription.java:        subscriptions.add(notifications.registerNotificationListener(streamNameType,
      ./netconf/plugins/netconf-server-mdsal/src/main/java/org/opendaylight/netconf/server/mdsal/notifications/NetconfNotificationManager.java:    public synchronized Registration registerNotificationListener(final StreamNameType stream,
      ./netconf/plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/server/mdsal/notifications/NetconfNotificationManagerTest.java:        try (var reg = netconfNotificationManager.registerNotificationListener(
      ./netconf/plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/server/mdsal/notifications/NetconfNotificationManagerTest.java:        netconfNotificationManager.registerNotificationListener(
      ./netconf/plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/server/mdsal/notifications/NetconfNotificationManagerTest.java:        netconfNotificationManager.registerNotificationListener(testStream.getName(), listener);
      ./netconf/plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/server/mdsal/notifications/NetconfNotificationManagerTest.java:                .registerNotificationListener(NetconfNotificationManager.BASE_NETCONF_STREAM.getName(), listener);
      ./netconf/plugins/netconf-server-mdsal/src/test/java/org/opendaylight/netconf/server/mdsal/notifications/CreateSubscriptionTest.java:                .registerNotificationListener(any(StreamNameType.class), any(NetconfNotificationListener.class));
      ./netconf/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/spi/NetconfDeviceNotificationService.java:    public synchronized <T extends DOMNotificationListener> ListenerRegistration<T> registerNotificationListener(
      ./netconf/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/spi/NetconfDeviceNotificationService.java:    public synchronized <T extends DOMNotificationListener> ListenerRegistration<T> registerNotificationListener(
      ./netconf/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/spi/NetconfDeviceNotificationService.java:        return registerNotificationListener(listener, Lists.newArrayList(types));
      ./netconf/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/spi/NetconfDeviceNotificationService.java:    public synchronized Registration registerNotificationListeners(
      ./netconf/plugins/netconf-client-mdsal/src/test/java/org/opendaylight/netconf/client/mdsal/spi/NetconfDeviceNotificationServiceTest.java:        service.registerNotificationListener(listener1, path1);
      ./netconf/plugins/netconf-client-mdsal/src/test/java/org/opendaylight/netconf/client/mdsal/spi/NetconfDeviceNotificationServiceTest.java:        registration = service.registerNotificationListener(listener2, path2);
      ./netconf/netconf/tools/netconf-test-perf/src/main/java/org/opendaylight/netconf/test/perf/MountedDeviceListener.java:        listeners.put(path, notificationService.registerNotificationListener(
      ./netconf/protocol/netconf-server/src/main/java/org/opendaylight/netconf/server/api/notifications/NetconfNotificationRegistry.java:    @NonNull Registration registerNotificationListener(@NonNull StreamNameType stream,
      ./netconf/restconf/sal-restconf-broker/src/main/java/org/opendaylight/netconf/sal/restconf/broker/impl/DataBrokerServiceImpl.java:        final ListenerRegistration<?> reg = restConfListenableEventStreamContext.registerNotificationListener(remoteDataChangeNotificationListener);
      ./netconf/restconf/sal-restconf-broker/src/main/java/org/opendaylight/netconf/sal/restconf/broker/impl/NotificationServiceImpl.java:    public <T extends Notification> ListenerRegistration<NotificationListener<T>> registerNotificationListener(Class<T> notificationType, NotificationListener<T> listener) {
      ./netconf/restconf/sal-restconf-broker/src/main/java/org/opendaylight/netconf/sal/restconf/broker/impl/NotificationServiceImpl.java:                .registerNotificationListener(remoteNotificationListener);
      ./netconf/restconf/sal-restconf-broker/src/main/java/org/opendaylight/netconf/sal/restconf/broker/impl/NotificationServiceImpl.java:    public ListenerRegistration<org.opendaylight.yangtools.yang.binding.NotificationListener> registerNotificationListener(org.opendaylight.yangtools.yang.binding.NotificationListener listener) {
      ./netconf/restconf/sal-restconf-broker/src/main/java/org/opendaylight/netconf/sal/restconf/broker/impl/NotificationServiceImpl.java:        return restconfClientContext.getEventStreamContext(desiredEventStream.get(desiredEventStream.get(notificationStreamName))).registerNotificationListener(listener);
      ./netconf/restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/rests/services/impl/RestconfDataServiceImpl.java:            : listenersBroker.registerNotificationListener(Absolute.of(notifName), streamName, outputType);
      ./netconf/restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/streams/listeners/DeviceNotificationListenerAdaptor.java:            setRegistration(notificationService.registerNotificationListener(this, paths));
      ./netconf/restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/streams/listeners/NotificationListenerAdapter.java:            setRegistration(notificationService.registerNotificationListener(this, getSchemaPath()));
      ./netconf/restconf/restconf-nb/src/main/java/org/opendaylight/restconf/nb/rfc8040/streams/listeners/ListenersBroker.java:    public NotificationListenerAdapter registerNotificationListener(final Absolute schemaPath,
      ./netconf/restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/streams/listeners/JsonNotificationListenerTest.java:        final NotificationListenerAdapter notifiAdapter = ListenersBroker.getInstance().registerNotificationListener(
      ./netconf/restconf/restconf-nb/src/test/java/org/opendaylight/restconf/nb/rfc8040/streams/listeners/XmlNotificationListenerTest.java:        final NotificationListenerAdapter notifiAdapter = ListenersBroker.getInstance().registerNotificationListener(

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              rkashapov Ruslan Kashapov
              rkashapov Ruslan Kashapov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: