Uploaded image for project: 'netconf'
  1. netconf
  2. NETCONF-248

Incorrect handling of configuration failures in SAL netconf connector

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • None
    • None
    • netconf
    • None
    • Operating System: All
      Platform: All

    • 6343

    Description

      Version: 1.1.0-SNAPSHOT (Boron) (master branch)

      SAL netconf connector handles invalid configuration just by logging warning message what casues that RESTCONF response indicates result code 200 OK.

      Possible solution:
      https://git.opendaylight.org/gerrit/gitweb?p=netconf.git;a=blob;f=netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java;h=4001c3186b385d16b376421256c9ac66c3dba224;hb=refs/heads/master#l192

      In the method onSuccess() there's a check isSuccess(). If the isSuccess returns false, then the warning message is logged. But there should be used the same handling as in the method onFailure().

      See attached logs for more details.

      Attachments

        1. netconf_sal_connector_karaf.log
          365 kB
          tomas.janciga@pantheon.tech
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jmorvay@cisco.com Jakub Morvay
            tjanciga Tomas Janciga
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: