Details
-
Task
-
Status: Confirmed
-
Medium
-
Resolution: Unresolved
-
None
-
None
-
None
Description
The only thing ODLMICRO-24 can reasonably want now is that restconf-nb provides correct @Singleton annotations. This depends on NETCONF-959, which will clean up the lifecycle enough for this to be feasible.
At the end of the day, Guice does not really deal with configuration injection of which restconf-nb has plenty. It also has a ton of invalid Singletons, as it really should only be wired through JaxRsNortbound.
Add @Singleton annotation to it an provide an @Inject constructor, which will just take default values. Also remove any other @Singletons we end up overriding – for example RestconfApplication, which just cannot work (because of StreamsConfiguration).
Attachments
Issue Links
- blocks
-
ODLMICRO-24 Move blue print xml declarations to annotations from netconf modules
-
- Confirmed
-
- is blocked by
-
NETCONF-959 Convert restconf-nb to OSGi Declarative Services
-
- Resolved
-
Gerrit Reviews
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 91316,10 | Adding Inject and Singleton annotations | master | netconf | Status: ABANDONED | -1 | +1 |
| 91445,3 | Moving Netconf-topology-impl module's blue print xml declarations to annotations | master | netconf | Status: ABANDONED | 0 | -1 |
| 91547,1 | Moving Netconf-topology-singleton module's blue print xml declarations to annotations | master | netconf | Status: ABANDONED | 0 | -1 |