Details
-
Epic
-
Status: Confirmed
-
Highest
-
Resolution: Unresolved
-
None
-
None
-
Rewire restconf-nb
Description
Wiring of services and component interactions are an utter mess in this component – mostly due to a number of half-finished/unexplained migrations dating back years.
This revolves around JSONRestconfService, Handler and UpdateHandlers, as well as various Wrapper interfaces – their interaction with individual utilities, implementations, Blueprint XML as well as javax.inject annotations (and their injection wiring).
All of this needs to be cleaned up, so that proper lifecycle is obvious and we do not have useless layers and indirections.
Attachments
Issue Links
- relates to
-
NETCONF-774 Remove the ability to select DOMDataBroker wiring
-
- Resolved
-
-
NETCONF-781 HTTP ERROR 500 Request failed on restconf POST
-
- Resolved
-
-
-
- Confirmed
-
Gerrit Reviews
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 108909,5 | WIP: Add LocalRestconfStreamRegistry | master | netconf | Status: NEW | 0 | -1 |
| 108916,2 | Use DatabindContext in stream formatters | master | netconf | Status: NEW | 0 | -1 |
| 108918,2 | WIP: Pass DatabindContext to body parsers | master | netconf | Status: NEW | 0 | -1 |
| 96162,2 | Remove JSONRestconfService | master | netconf | Status: MERGED | +2 | +1 |
| 96164,2 | Remove UpdateHandlers | master | netconf | Status: MERGED | +2 | +1 |
| 96165,1 | Remove Handler interface | master | netconf | Status: MERGED | +2 | +1 |
| 96166,2 | Remove ActionServiceHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96167,2 | Remove RpcServiceHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96168,1 | Remove NotificationServiceHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96169,3 | Remove DOMDataBrokerHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96170,2 | Remove DOMMountPointServiceHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96171,3 | Reduce preliferation of TransactionChainHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96190,1 | Clean up Root Resource Discovery implementation | master | netconf | Status: MERGED | +2 | +1 |
| 96194,1 | Reuse local RestconfStrategy | master | netconf | Status: MERGED | +2 | +1 |
| 96195,1 | Move services API | master | netconf | Status: MERGED | +2 | +1 |
| 96196,2 | Remove {Base,Transaction}ServicesWrapper | master | netconf | Status: MERGED | +2 | +1 |
| 96199,2 | Unmask NotificationListenerAdapter | master | netconf | Status: MERGED | +2 | +1 |
| 96200,1 | Remove Service(Notif)Wrapper | master | netconf | Status: MERGED | +2 | +1 |
| 96202,1 | Unmask NotificationListenerAdapter | master | netconf | Status: MERGED | +2 | +1 |
| 96203,1 | Remove SSEInitializer | master | netconf | Status: MERGED | +2 | +1 |
| 96261,1 | Cleanup Rfc8040 constants | master | netconf | Status: MERGED | +2 | +1 |
| 96268,3 | Refactor constants relating to restconf-monitoring | master | netconf | Status: MERGED | +2 | +1 |
| 96269,2 | Use ImmutableNodes.leafNode() | master | netconf | Status: MERGED | +2 | +1 |
| 96270,2 | Refactor ietf-restconf constants | master | netconf | Status: MERGED | +2 | +1 |
| 96395,1 | Correct stream instance identifier | master | netconf | Status: MERGED | +2 | +1 |
| 96844,3 | Use free-standing transaction in SubscribeToStreamUtil | master | netconf | Status: MERGED | +2 | +1 |
| 96845,7 | Reduce use of TransactionChainHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96846,6 | Remove TransactionChainHandler | master | netconf | Status: MERGED | +2 | +1 |
| 96849,3 | Remove MessageBodyWriter.getSize() implementations | master | netconf | Status: MERGED | +2 | +1 |
| 96850,3 | Refactor source export | master | netconf | Status: MERGED | +2 | +1 |
| 96851,3 | Move AbstractNormalizedNodeBodyReader | master | netconf | Status: MERGED | +2 | +1 |
| 96852,3 | Add AbstractNormalizedNodeBodyWriter | master | netconf | Status: MERGED | +2 | +1 |
| 96853,3 | Add AbstractPatchStatusBodyWriter | master | netconf | Status: MERGED | +2 | +1 |
| 96854,3 | Move validation methods | master | netconf | Status: MERGED | +2 | +1 |
| 96855,1 | Rename {Xml,Json}ToPatchBodyReader | master | netconf | Status: MERGED | +2 | +1 |
| 96857,3 | Clean up listener activation | master | netconf | Status: MERGED | +2 | +1 |
| 96858,2 | Clean up RestconfInvokeOperationsUtil | master | netconf | Status: MERGED | +2 | +1 |
| 97481,3 | Do not pass RestconfStrategy to FutureCallbackTx | master | netconf | Status: MERGED | +2 | +1 |
| 97483,3 | Cleanup RestconfInvokeOperationsUtilTest | master | netconf | Status: MERGED | +2 | +1 |
| 97484,4 | Remove RestconfInvokeOperationsUtilTest | master | netconf | Status: MERGED | +2 | +1 |
| 97485,5 | Remove RestconfInvokeOperationsUtil | master | netconf | Status: MERGED | +2 | +1 |
| 97487,2 | Remove DataChangeScope | master | netconf | Status: MERGED | +2 | +1 |
| 98064,4 | Split out RFC8040-only constructs from yang-common | master | netconf | Status: MERGED | +2 | +1 |
| 98065,3 | Move WriterParameters.tagged | master | netconf | Status: MERGED | +2 | +1 |
| 98086,6 | Add representations of RFC8040 query parameters | master | netconf | Status: MERGED | +2 | +1 |
| 98088,5 | Deprecate NormalizedNodeContext | master | netconf | Status: MERGED | +2 | +1 |
| 98089,6 | Disconnect QueryParameters from WriterParameters | master | netconf | Status: MERGED | +2 | +1 |
| 98091,3 | Hide NormalizedNodeContext and WriterParameters | master | netconf | Status: MERGED | +2 | +1 |
| 98093,3 | FilterParameter now has a YangXPathExpression | master | netconf | Status: MERGED | +2 | +1 |
| 98096,3 | Rework query parameter parsing | master | netconf | Status: MERGED | +2 | +1 |
| 98098,1 | Remove Rfc8040.Capabilities | master | netconf | Status: MERGED | +2 | +1 |
| 98099,1 | Move RestconfMappingNodeUtil.mapCapabilites() | master | netconf | Status: MERGED | +2 | +1 |
| 98100,2 | Use parameters in StreamSubscriptionServiceImpl | master | netconf | Status: MERGED | +2 | +1 |
| 98101,1 | Cleanup AbstractQueryParams | master | netconf | Status: MERGED | +2 | +1 |
| 98102,1 | Use FilterParameter for communicating its value | master | netconf | Status: MERGED | +2 | +1 |
| 98103,4 | Promote NotificationQueryParams | master | netconf | Status: MERGED | +2 | +1 |
| 98104,4 | Introduce UriInfoSupport | master | netconf | Status: MERGED | +2 | +1 |
| 98105,3 | Promote QueryParams as WriteDataParams | master | netconf | Status: MERGED | +2 | +1 |
| 98107,1 | Move ReadDataTransactionUtil.parseUriParameters() | master | netconf | Status: MERGED | +2 | +1 |
| 98108,4 | Move simple QueryParams tests | master | netconf | Status: MERGED | +2 | +1 |
| 98111,1 | Separate out ReadDataParams | master | netconf | Status: MERGED | +2 | +1 |
| 98113,2 | Add RestconfQueryParam | master | netconf | Status: MERGED | +2 | +1 |
| 98115,1 | Refactor QueryParams.newReadDataParams() | master | netconf | Status: MERGED | +2 | +1 |
| 98116,1 | Expose parameter names as String constants | master | netconf | Status: MERGED | +2 | +1 |
| 98128,1 | Cleanup FieldsParam | master | netconf | Status: MERGED | +2 | +1 |
| 98129,2 | Refactor ParserFieldsParameter | master | netconf | Status: MERGED | +2 | +1 |
| 98130,4 | Update AbstractQueryParams | master | netconf | Status: MERGED | +2 | +1 |
| 98134,1 | Eliminate AbstractQueryParams | master | netconf | Status: MERGED | +2 | +1 |
| 98135,2 | Integrate AbstractCommonSubscriber more tightly | master | netconf | Status: MERGED | +2 | +1 |
| 98138,1 | Unify parameter parsing | master | netconf | Status: MERGED | +2 | +1 |
| 107840,5 | Move JAX-RS patch providers | master | netconf | Status: MERGED | +2 | +1 |
| 107869,2 | Refactor NormalizedNodePayload | master | netconf | Status: MERGED | +2 | +1 |
| 107872,2 | Bind RestconfStrategy to EffectiveModelContext | master | netconf | Status: MERGED | +2 | +1 |
| 107876,2 | Bind Insert point PathArgument earlier | master | netconf | Status: MERGED | +2 | +1 |
| 107885,2 | Make DatabindContext codecs lazily-loaded | master | netconf | Status: MERGED | +2 | +1 |
| 108537,3 | Move ErrorTags | master | netconf | Status: MERGED | +2 | +1 |
| 108877,11 | Introduce restconf.server.{api,spi,mdsal} | master | netconf | Status: MERGED | +2 | +1 |
| 108906,2 | Eliminate RestconfInvokeOperationsServiceImpl | master | netconf | Status: MERGED | +2 | +1 |
| 108910,6 | Wire RestconfImpl to MdsalRestconfServer | master | netconf | Status: MERGED | +2 | +1 |
| 108917,11 | Establish ietf-yang-library revision from model context | master | netconf | Status: MERGED | +2 | +1 |
| 108998,1 | Codify RestconfServer.yangLibraryVersionGET() | master | netconf | Status: MERGED | +2 | +1 |
| 108999,2 | Document RestconfServer.invokeRpc() | master | netconf | Status: MERGED | +2 | +1 |
| 109000,2 | Codify operationsGET | master | netconf | Status: MERGED | +2 | +1 |
| 109001,2 | Rehost OperationsContent.bodyFor() | master | netconf | Status: MERGED | +2 | +1 |
| 109002,5 | Refactor OperationsContent | master | netconf | Status: MERGED | +2 | +1 |
| 109005,5 | Fix single-item OperationsContent | master | netconf | Status: MERGED | +2 | +1 |
| 109006,4 | Eliminate RestconfOperationsServiceImpl | master | netconf | Status: MERGED | +2 | +1 |
| 109007,4 | Move action invocation to MdsalRestconfServer | master | netconf | Status: MERGED | +2 | +1 |
| 109008,3 | Introduce asynchronous RestconfServer.readData() | master | netconf | Status: MERGED | +2 | +1 |
| 109009,2 | Move /data GET methods to RestconfImpl | master | netconf | Status: MERGED | +2 | +1 |
| 109010,3 | Move bindResourceRequest() | master | netconf | Status: MERGED | +2 | +1 |
| 109011,2 | Add RestconfServer.dataDELETE() | master | netconf | Status: MERGED | +2 | +1 |
| 109012,2 | Add RestconfServer.dataPATCH() | master | netconf | Status: MERGED | +2 | +1 |
| 109013,5 | Clean up getStatusCode() | master | netconf | Status: MERGED | +2 | +1 |
| 109014,2 | Introduce RestconfServer methods for YANG Patch | master | netconf | Status: MERGED | +2 | +1 |
| 109015,3 | Introduce RestconfServer.dataPUT() operations | master | netconf | Status: MERGED | +2 | +1 |
| 109016,2 | Rename OperationsContent | master | netconf | Status: MERGED | +2 | +1 |
| 109017,4 | Add DataPostResult | master | netconf | Status: MERGED | +2 | +1 |
| 109018,3 | Introduce RestconfServer.dataPOST() | master | netconf | Status: MERGED | +2 | +1 |
| 109019,4 | Move MdsalRestconfServer | master | netconf | Status: MERGED | +2 | +1 |
| 109020,3 | Introduce restconf.nb.jaxrs package | master | netconf | Status: MERGED | +2 | +1 |
| 109021,3 | Split up MediaTypes | master | netconf | Status: MERGED | +2 | +1 |
| 109022,3 | Move DOMDatabindProvider | master | netconf | Status: MERGED | +2 | +1 |
| 109040,4 | Eliminate nb.rfc8040.rests.services.api | master | netconf | Status: MERGED | +2 | +1 |
| 109042,3 | Clean up SchemaExportContext | master | netconf | Status: MERGED | +2 | +1 |
| 109043,4 | ApiPath is a HierarchicalIdentifier | master | netconf | Status: MERGED | +2 | +1 |
| 109044,4 | Relocate ParserIdentifier methods | master | netconf | Status: MERGED | +2 | +1 |
| 109052,5 | Eliminate RestconfSchemaServiceImpl | master | netconf | Status: MERGED | +2 | +1 |
| 109058,4 | Fix operations{Json,Xml}GET definition | master | netconf | Status: MERGED | +2 | +1 |
| 109060,2 | Add FIXMEs | master | netconf | Status: MERGED | +2 | +1 |
| 109061,2 | Fix /operations indexing | master | netconf | Status: MERGED | +2 | +1 |
| 109066,1 | Remove ParserConstants | master | netconf | Status: MERGED | +2 | +1 |
| 109083,1 | Promote DatabindContext to restconf.server.api | master | netconf | Status: MERGED | +2 | +1 |
| 109086,1 | Promote OperationOutput to restconf.server.api | master | netconf | Status: MERGED | +2 | +1 |
| 109092,1 | Remove an obsolete FIXME | master | netconf | Status: MERGED | +2 | +1 |
| 109100,1 | Remove yang.model.api fakes for /restconf/operations | master | netconf | Status: MERGED | +2 | +1 |
| 109101,1 | Remove SSEApplication | master | netconf | Status: MERGED | +2 | +1 |
| 109102,1 | Refactor root resource discovery | master | netconf | Status: MERGED | +2 | +1 |
| 109103,1 | Move RestconfSchemaSourceUrlProvider | master | netconf | Status: MERGED | +2 | +1 |
| 109104,2 | Refactor ReadDataParams | master | netconf | Status: MERGED | +2 | +1 |
| 109105,2 | Reorder QueryParams | master | netconf | Status: MERGED | +2 | +1 |
| 109106,1 | Cleanup restconf-nb dependencies | master | netconf | Status: MERGED | +2 | +1 |
| 109107,1 | Refactor ReceiveEventsParams | master | netconf | Status: MERGED | +2 | +1 |
| 109108,1 | Inline RestconfApplication | master | netconf | Status: MERGED | +2 | +1 |
| 109109,1 | Do not hide DataGetParams.EMPTY | master | netconf | Status: MERGED | +2 | +1 |
| 110001,3 | Add transport-http | master | netconf | Status: MERGED | +2 | +1 |
| 110002,3 | Add restconf-{client,server} | master | netconf | Status: MERGED | +2 | +1 |