Details
-
Improvement
-
Status: Resolved
-
Medium
-
Resolution: Done
-
None
Description
In sal-rest-docgen package there is a lot of usages of Optional<> type as method parameter. That’s discouraged: https://stackoverflow.com/questions/31922866/why-should-java-8s-optional-not-be-used-in-arguments.
We can get rid of this problem by slightly reworking our code.
Complete work on https://git.opendaylight.org/gerrit/c/netconf/+/105646 and create additional patches which deals with other occurrences of this problem in sal-rest-docgen package.
Attachments
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 105646,19 | Do not use Optional with method parameters | master | netconf | Status: ABANDONED | -1 | -1 |
| 106235,12 | Update constructors, remove Optional, add non-null | master | netconf | Status: MERGED | +2 | +1 |
| 106236,15 | Replace Optional range with separate methods | master | netconf | Status: MERGED | +2 | +1 |
| 106237,15 | Remove Optional for deviceName parameter | master | netconf | Status: MERGED | +2 | +1 |
| 106239,10 | Simplify element count processing, remove Optional | master | netconf | Status: MERGED | +2 | +1 |
| 106244,10 | Introduce overloaded buildResponse methods | master | netconf | Status: MERGED | +2 | +1 |
| 106256,11 | Eliminate code duplication in doc creation | master | netconf | Status: MERGED | +2 | +1 |
