[NETVIRT-1076] NeutronVpnManager: refactor associateNetworksToVpn: contains arrow anti-pattern - OpenDaylight JIRA

XML

Word

Printable

Details

Type: Improvement
Status: Resolved
Priority: Medium
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

associateNetworksToVpn needs to be refactored to avoid arrow anti-pattern

https://git.opendaylight.org/gerrit/#/c/57411/153/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java@2241

Due to regression tests, it works:

https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/netvirt-csit-1node-openstack-ocata-upstream-stateful-oxygen/822/log_full.html.gz#s1-s7

But it is worth to refactor this monster !

Attachments

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

No reviews matched the request. Check your Options in the drop-down menu of this sections header.

Activity

People

Assignee:: Valentina Krasnobaeva

Reporter:: Valentina Krasnobaeva

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 01/Feb/18 6:48 PM

Updated:: 05/Apr/18 9:31 PM

Resolved:: 05/Apr/18 9:31 PM