Uploaded image for project: 'neutron'
  1. neutron
  2. NEUTRON-118

Broken retry logic in updateMd() using transaction chain

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Duplicate
    • unspecified
    • None
    • transcriber
    • None
    • Operating System: All
      Platform: All

    • 5621

    Description

      Retry logic present at the following location is not correct.

      https://github.com/opendaylight/neutron/blob/master/transcriber/src/main/java/org/opendaylight/neutron/transcriber/AbstractNeutronInterface.java#L172

      Whenever a transaction fails, it will mark the transaction chain as failed, so any retry using the same transaction chain will fail, because cluster data broker check transaction chain state before submitting any new transaction.

      https://github.com/opendaylight/controller/blob/master/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/DOMBrokerTransactionChain.java#L84

      So with the current logic, if the first attempt fails, consecutive attempt will also fail.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Avishnoi Anil Vishnoi
              Avishnoi Anil Vishnoi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: