Details
-
Bug
-
Status: Resolved
-
Resolution: Done
-
unspecified
-
None
-
None
-
Operating System: All
Platform: All
-
3902
Description
package org.opendaylight.neutron.transcriber;
class : public abstract class AbstractNeutronInterface
1. This can be made final --> private DataBroker db;
2. Class can have a header comment
public class Activator implements BundleActivator
1. can be made final --> private ProviderContext providerContext;
2. As a general practice local variables can be made final
public class NeutronFloatingIPInterface extends
1. can be made final --> private ConcurrentMap<String, NeutronFloatingIP> floatingIPDB = new ConcurrentHashMap<String, NeutronFloatingI
2. unused variable --> NeutronSubnet subnet = subnetCRUD.getSubnet(networkCRUD.getNetwork(floatIP.getFloatingNetworkUUID()).getSubnets().get(0));
public class NeutronLoadBalancerInterface extends
1. can be made final --> private ConcurrentMap<String, eutronLoadBalancer> loadBalancerDB
similar conventions can be verified in other classes