Uploaded image for project: 'OpenFlowPlugin'
  1. OpenFlowPlugin
  2. OPNFLWPLUG-185

checkOdAction method of TestFromSalConversionsUtils class doesn't use third parameter.

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • None
    • None
    • General
    • None
    • Operating System: Linux
      Platform: PC

    • 1178

    Description

      Please see the following file.

      controller/opendaylight/md-sal/compatibility/sal-compatibility/src/test/java/org/opendaylight/controller/sal/compatibility/test/TestFromSalConversionsUtils.java

      checkOdAction method is invoked by checkOdActions method as follows.

      224 private void checkOdActions(
      225 List<org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action> actions)

      { 226 checkOdAction(actions, FloodActionCase.class, false); 227 checkOdAction(actions, FloodAllActionCase.class, false); 228 checkOdAction(actions, HwPathActionCase.class, false); 229 checkOdAction(actions, LoopbackActionCase.class, false); 230 checkOdAction(actions, PopVlanActionCase.class, false); 231 checkOdAction(actions, PushVlanActionCase.class, true); 232 checkOdAction(actions, SetDlDstActionCase.class, true); 233 checkOdAction(actions, SetDlSrcActionCase.class, true); 234 checkOdAction(actions, SetDlTypeActionCase.class, true); 235 checkOdAction(actions, SetNwTosActionCase.class, true); 236 checkOdAction(actions, SetNwDstActionCase.class, true); 237 checkOdAction(actions, SetNwSrcActionCase.class, true); 238 checkOdAction(actions, SetNextHopActionCase.class, true); 239 checkOdAction(actions, SetTpDstActionCase.class, true); 240 checkOdAction(actions, SetTpSrcActionCase.class, true); 241 checkOdAction(actions, SetVlanCfiActionCase.class, true); 242 checkOdAction(actions, SetVlanIdActionCase.class, true); 243 checkOdAction(actions, SetVlanPcpActionCase.class, true); 244 checkOdAction(actions, SwPathActionCase.class, false); 245 }

      However, checkOdAction method doesn't use its third parameter at all.

      [The code I checked]

      I checked the latest code of controller project on 10th June.

      odc180 $ git log -3 --oneline
      16fcdf1 Merge changes I057476f2,I5b8602e7
      9ba0d83 Merge "CONTROLLER-549: ContainerFlow boundary is not always enforced for vlans"
      43d9468 BUG-981: Fix XML serialization test

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              vdemcak@cisco.com Vaclav Demcak
              Hideyuki1985 Hideyuki Tai
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: