Details
-
Bug
-
Status: Resolved
-
Resolution: Done
-
None
-
None
-
None
-
Operating System: All
Platform: All
-
5592
Description
Subclasses of org.opendaylight.openflowplugin.impl.services.AbstractService should have their own field for accessing NodeId+DatapathId+version. For example these classes use NodeId/DatapathId just for logging:
a/ org.opendaylight.openflowplugin.impl.statistics.services.dedicated.StatisticsGatheringService
b/ org.opendaylight.openflowplugin.impl.statistics.services.dedicated.StatisticsGatheringOnTheFlyService
c/ org.opendaylight.openflowplugin.impl.statistics.services.MatchingFlowsInTableService
d/ ... (all other subclasses)
Lets used DeviceState for accessing at least:
- nodeId
- version
- datapathId (accesible in DeviceState.getFeatures())
This deviceContext is propagated also to this transform utility functions but it is not necessary (propagate there only DeviceState):
e/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.FlowStatisticsToNotificationTransformer.transformToNotification(List<MultipartReply>, DeviceContext, OpenflowVersion, TransactionId)
f/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.GroupStatisticsToNotificationTransformer.transformToNotification(List<MultipartReply>, DeviceContext, OpenflowVersion, TransactionId)
g/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.MeterStatisticsToNotificationTransformer.transformToNotification(List<MultipartReply>, DeviceContext, OpenflowVersion, TransactionId)
h/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.QueueStatisticsToNotificationTransformer.transformToNotification(List<MultipartReply>, DeviceContext, OpenflowVersion, TransactionId)
i/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.NodeConnectorStatisticsToNotificationTransformer.transformToNotification(List<MultipartReply>, DeviceContext, OpenflowVersion, TransactionId)
j/ org.opendaylight.openflowplugin.impl.statistics.services.compatibility.QueueStatisticsToNotificationTransformer.transformToNotification(List<MultipartReply>, DeviceContext, OpenflowVersion, TransactionId)
