Uploaded image for project: 'transportpce'
  1. transportpce
  2. TRNSPRTPCE-121

Unreachable catch in ServicehandlerTxRxCheck

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Lowest Lowest
    • None
    • None
    • None
    • None

      In the method check in class ServicehandlerTxRxCheck the NullPointerException catch is unreachable

      if (serviceEnd != null) {
          try {
              Long serviceRate = serviceEnd.getServiceRate();
              ServiceFormat serviceformat = serviceEnd.getServiceFormat();
              String clli = serviceEnd.getClli();
              if ((serviceRate == null) || (serviceRate <= 0)) {
                  result = false;
                  message = "Service " + endpointType + " rate is not set";
                  LOG.debug(message);
              } else if (serviceformat == null) {
                  result = false;
                  message = "Service " + endpointType + " format is not set";
                  LOG.debug(message);
              } else if (!checkString(clli)) {
                  result = false;
                  message = "Service" + endpointType + " clli format is not set";
                  LOG.debug(message);
              } else {
                  ComplianceCheckResult complianceCheckResult
                          = checkTxOrRxInfo(serviceEnd.getTxDirection(), serviceEnd.getRxDirection());
                  if (!complianceCheckResult.hasPassed()) {
                      result = false;
                      message = complianceCheckResult.getMessage();
                  }
              }
          } catch (NullPointerException e) {
              message = "Service " + endpointType + " rate, format or clli is not set";
              LOG.error(message, e);
              return new ComplianceCheckResult(false, message);
          }
      } else {
          result = false;
          message = endpointType + " is not set";
          LOG.debug(message);
      }
      

            Unassigned Unassigned
            ramy1313 Rami Mohamed
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: