Uploaded image for project: 'transportpce'
  1. transportpce
  2. TRNSPRTPCE-146

Unused PCE code

    XMLWordPrintable

Details

    • Improvement
    • Status: Verified
    • Low
    • Resolution: Done
    • None
    • None
    • None
    • None

    Description

      In the pathComputation() method in PceSendingPceRPCs.java there is the following code:

      // TODO fix. This is quick workaround for algorithm problem
if ((rc.getLocalCause() == PceResult.LocalCause.TOO_HIGH_LATENCY)
        && (pceHardConstraints.getPceMetrics() == PceMetric.HopCount)
        && (pceHardConstraints.getMaxLatency() != -1)) {
    pceHardConstraints.setPceMetrics(PceMetric.PropagationDelay);
    graph = patchRerunGraph(graph);
}

      This code does not seem to be relevant anymore with the new PCE implementation. LocalCause.TOO_HIGH_LATENCY is never set anywhere.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            atriki Ahmed Triki
            ojnas Jonas Mårtensson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days
                2d