Uploaded image for project: 'transportpce'
  1. transportpce
  2. TRNSPRTPCE-644

Refactor SupportedIfCapability usage

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Medium Medium
    • Phosphorus
    • None
    • None
    • None

      When an openROADM device is getting connected to TransportPCE, portmapping stores the device supported-If-capability. Since TransportPCE manages at least three device versions, these supported-if-capability may have at least three different namespaces, what has led us to sometimes use specific methods to just convert the namespace, elsewhere in other part of the code which deals with these supported-if-captbility.

      With migration of service and network models to release 10.1, another version of supported-if-capabiilty is added, and additional converting methods have been added on the code.

      To avoid such useless code duplication, and at the same time to simplify the maintainability of the code, it would be better to simplify this supported-if-capability conversion process. For this, it would be wise to:

      • gather all supported-if-capabilities managed in TransportPCE, in their latests version, in the capTypeClassMap Map of MappingUtilsImpl utilitary class which already supports a convertSupIfCapa() method,
      • systematically use that latter in the PortMappingVersionXXX classes to align all supported-if-capability of portmapping on the latest version
      • reuse without any conversion supported-if-capability from portmapping everywhere else it is needed in the rest of the code.

            gthouenon Gilles Thouenon
            gthouenon Gilles Thouenon
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days
                2d