Uploaded image for project: 'transportpce'
  1. transportpce
  2. TRNSPRTPCE-752

Do not use RpcService in TRANSPORTPCE components

    XMLWordPrintable

Details

    • Task
    • Status: Verified
    • High
    • Resolution: Done
    • None
    • Calcium
    • None
    • None

    Description

      A quick grep is showing these users of deprecated API:

      ./transportpce/nbinotifications/src/main/java/org/opendaylight/transportpce/nbinotifications/impl/NbiNotificationsProvider.java:        rpcRegistrations.add(rpcProviderService.registerRpcImplementation(NbiNotificationsService.class, nbiImpl));
      ./transportpce/nbinotifications/src/main/java/org/opendaylight/transportpce/nbinotifications/impl/NbiNotificationsProvider.java:        rpcRegistrations.add(rpcProviderService.registerRpcImplementation(TapiNotificationService.class, nbiImpl));
      ./transportpce/nbinotifications/src/test/java/org/opendaylight/transportpce/nbinotifications/impl/NbiNotificationsProviderTest.java:                .registerRpcImplementation(any(), any(NbiNotificationsImpl.class));
      ./transportpce/networkmodel/src/main/java/org/opendaylight/transportpce/networkmodel/NetworkModelProvider.java:            .registerRpcImplementation(TransportpceNetworkutilsService.class, networkutilsService);
      ./transportpce/networkmodel/src/test/java/org/opendaylight/transportpce/networkmodel/NetworkModelProviderTest.java:            .registerRpcImplementation(any(), any(TransportpceNetworkutilsService.class));
      ./transportpce/olm/src/main/java/org/opendaylight/transportpce/olm/OlmProvider.java:        olmRPCRegistration = rpcProviderService.registerRpcImplementation(TransportpceOlmService.class,
      ./transportpce/pce/src/main/java/org/opendaylight/transportpce/pce/impl/PceProvider.java:        rpcRegistration = rpcService.registerRpcImplementation(TransportpcePceService.class, consumer);
      ./transportpce/pce/src/test/java/org/opendaylight/transportpce/pce/impl/PceProviderTest.java:        verify(rpcService, times(1)).registerRpcImplementation(any(), any(TransportpcePceService.class));
      ./transportpce/renderer/src/main/java/org/opendaylight/transportpce/renderer/RendererProvider.java:                .registerRpcImplementation(TransportpceDeviceRendererService.class, deviceRendererRPCImpl);
      ./transportpce/renderer/src/main/java/org/opendaylight/transportpce/renderer/RendererProvider.java:                .registerRpcImplementation(TransportpceRendererService.class, transportPCEServicePathRPCImpl);
      ./transportpce/renderer/src/test/java/org/opendaylight/transportpce/renderer/RendererProviderTest.java:            .registerRpcImplementation(any(), any(DeviceRendererRPCImpl.class));
      ./transportpce/renderer/src/test/java/org/opendaylight/transportpce/renderer/RendererProviderTest.java:            .registerRpcImplementation(any(), any(TransportPCEServicePathRPCImpl.class));
      ./transportpce/servicehandler/src/main/java/org/opendaylight/transportpce/servicehandler/impl/ServicehandlerProvider.java:            .registerRpcImplementation(OrgOpenroadmServiceService.class, servicehandler);
      ./transportpce/servicehandler/src/test/java/org/opendaylight/transportpce/servicehandler/impl/ServicehandlerProviderTest.java:        verify(rpcProviderRegistry, times(1)).registerRpcImplementation(any(), any(OrgOpenroadmServiceService.class));
      ./transportpce/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/TapiProvider.java:        rpcProviderService.registerRpcImplementation(TapiCommonService.class, topo);
      ./transportpce/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/TapiProvider.java:        rpcProviderService.registerRpcImplementation(TapiTopologyService.class, topo);
      ./transportpce/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/TapiProvider.java:                rpcProviderService.registerRpcImplementation(TransportpceTapinetworkutilsService.class,
      ./transportpce/tapi/src/main/java/org/opendaylight/transportpce/tapi/impl/TapiProvider.java:        rpcRegistration = rpcProviderService.registerRpcImplementation(TapiConnectivityService.class, tapi);
      ./transportpce/tapi/src/test/java/org/opendaylight/transportpce/tapi/provider/TapiProviderTest.java:        verify(rpcProviderRegistry, times(1)).registerRpcImplementation(any(), any(TapiConnectivityService.class));
      ./transportpce/tapi/src/test/java/org/opendaylight/transportpce/tapi/provider/TapiProviderTest.java:        verify(rpcProviderRegistry, times(2)).registerRpcImplementation(any(), any(TapiCommonService.class));
      ./transportpce/tapi/src/test/java/org/opendaylight/transportpce/tapi/provider/TapiProviderTest.java:        verify(rpcProviderRegistry, times(2)).registerRpcImplementation(any(), any(TapiTopologyService.class));
      

      Convert them to new-style yang.binding.Rpc-based implementations.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              gthouenon Gilles Thouenon
              rovarga Robert Varga
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days
                  4d