Uploaded image for project: 'yangtools'
  1. yangtools
  2. YANGTOOLS-1025

DataTreeModification does not require volatile seals

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Medium
    • Resolution: Done
    • None
    • 4.0.2
    • data-impl
    • None

    Description

      InMemoryDataTreeModification.isSealed() is invoked on every access, and it being volatile kind of hurts JIT's ability to optimize by reordering.

      We should be able to optimize isSealed() to be only an acquire load, without it being ordered against all other accesses. Note that seal() operation needs to be a volatile store, to ensure that happens-before is maintained across that boundary.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. YANGTOOLS-1537 CME in AbstractNodeContainerModificationStrategy.checkChildPreconditions()

          • Medium - Has the potential to affect progress.
          • Resolved
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              rovarga Robert Varga
              rovarga Robert Varga
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: