Uploaded image for project: 'yangtools'
  1. yangtools
  2. YANGTOOLS-1316

Re-examine argument storage in effective statements

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Medium Medium
    • 8.0.0
    • None
    • parser

      With YANGTOOLS-1066 out of the way it becomes obvious we may be storing the argument multiple times when we are dealing with original statement.

      More specifically, AbstractLeafEffectiveStatement has two specializations, storing argument in an explicit field. This statement is a CopyableNode, hence it may have an 'original' pointer – but when it does not, as is the case for EmptyLeafEffectiveStatement, the argument and declared.argument() should be pointing to the same thing. Hence we should be able to specialize a bit more.

      This is probably true of many other statements as well. Audit all statements bearing a QName argument.

            rovarga Robert Varga
            rovarga Robert Varga
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: