Uploaded image for project: 'yangtools'
  1. yangtools
  2. YANGTOOLS-343

Incorrect override of getUnknownNodes in TypeDefinitionBuilderImpl

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Resolution: Done
    • None
    • None
    • None
    • None
    • Operating System: All
      Platform: All

    • 2220

    Description

      Method getUnknownNodes is implemented in AbstractBuilder and should return list of added UnknownSchemaNodeBuilders. The TypeDefinitionBuilderImpl extends AbstractTypeAwareBuilder which extends AbstractBuilder.

      In TypeDefinitionBuilderImpl there is override of getUnknownNodes method which returns Collections.emptyList(). If this is intentional it should be at least commented since it brings confusion into code. If it is not intentional the override method should be removed from TypeDefinitionBuilderImpl.

      There is no possibility to copy of TypedefinitionBuilders UnknownNodes in CopyUtils.java for copy TypDefinitionBuilder since the getUnknownNodes will always be an empty list.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            pkajsa Peter Kajsa
            lsedlak@cisco.com Lukas Sedlak
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: