Binding DTOs: enums have inefficient forValue() implementation

YANG enumerations map to an enum, which has a forValue() method. This gets realized this way:

public enum BgpOrigin {
static java.util.Map<java.lang.Integer, BgpOrigin> valueMap;

static {
valueMap = new java.util.HashMap<>();
for (BgpOrigin enumItem : BgpOrigin.values())

{ valueMap.put(enumItem.value, enumItem); }

}

public static BgpOrigin forValue(int valueArg)

{ return valueMap.get(valueArg); }

}

There are multiple things wrong here:

• valueMap should be a proper constant
• valueMap has wrong name, should be all capitals
• valueMap should an ImmutableMap