[AAA-185] dev-guide.rst servlet instructions are incorrect Created: 05/Jun/19 Updated: 15/Aug/19 Resolved: 15/Aug/19 |
|
| Status: | Resolved |
| Project: | aaa |
| Component/s: | None |
| Affects Version/s: | Fluorine, Sodium, Neon SR1 |
| Fix Version/s: | Sodium, Fluorine SR3, Neon SR2 |
| Type: | Bug | Priority: | Highest |
| Reporter: | Kevin Smokowski | Assignee: | Mario Abraham |
| Resolution: | Done | Votes: | 0 |
| Labels: | pt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Can someone update dev-guide.rst if this class should have been deleted? It instructs users to use KarafIniWebEnvironment. It appears that class was deleted in https://git.opendaylight.org/gerrit/#/c/72528/ The instructions still appear on https://docs.opendaylight.org/projects/aaa/en/stable-fluorine/dev-guide.html#how-application-developers-can-leverage-aaa-to-provide-servlet-security If WebServer, WebContextSecurer and ServletSupport are the new classes to be used can some short summary be added in dev-guide.rst? |
| Comments |
| Comment by Robert Varga [ 07/Jun/19 ] |
|
Yes, those are the correct classes, for reference see: https://git.opendaylight.org/gerrit/68833 https://git.opendaylight.org/gerrit/69535 Unfortunately I do not have the cycles to update the docs |
| Comment by Robert Varga [ 07/Jun/19 ] |
|
Raising to blocker, so as this gets discussed at the TSC. It can be downgraded, but this would be an easy with for users. |
| Comment by Robert Varga [ 07/Jun/19 ] |
|
danieldelarosa we do not have to fix it before the release of SR3, it's just that we need a volunteer to provide a few lines/paragraphs in the docs... |
| Comment by Kevin Smokowski [ 10/Jun/19 ] |
|
rovarga can anyone (myself) raise a gerrit review? I was facing issues while trying this at my corporate office, I suspect the corporate firewall may be giving me issues that cause authentication to fail. Perhaps I could update this because it is simply a text file. |
| Comment by Jamo Luhrsen [ 27/Jun/19 ] |
|
nullopit would be awesome and greatly appreciated if you were to raise a gerrit on this. You can reach out on irc or mailing lists if you have trouble and hopefully someone can help |
| Comment by Kevin Smokowski [ 06/Aug/19 ] |
|
I was on a corporate network, when working on my personal machine on the public internet the issue went away. The corporate firewall doesn't like the port numbers setup for SSH I guess... |
| Comment by Kevin Smokowski [ 07/Aug/19 ] |
|
mario.abraham I opened up https://git.opendaylight.org/gerrit/c/aaa/+/83492 in an attempt to resolve this |
| Comment by Jamo Luhrsen [ 07/Aug/19 ] |
|
Thanks for the contribution. We just need someone relevant to review your patch now. rovarga, is it ok? I'll also ping the aaa-dev mailing |
| Comment by Mario Abraham [ 08/Aug/19 ] |
|
Thanks |
| Comment by Mario Abraham [ 08/Aug/19 ] |
|
Is new approach applicable also for Neon? Should be https://git.opendaylight.org/gerrit/c/aaa/+/83492 cherry-picked there? |
| Comment by Mario Abraham [ 08/Aug/19 ] |
|
I made cherry-pick on neon: https://git.opendaylight.org/gerrit/c/aaa/+/83525 |
| Comment by Kevin Smokowski [ 08/Aug/19 ] |
|
The change first happened in Fluorine so it applies to Fluorine and anything after. |
| Comment by Mario Abraham [ 08/Aug/19 ] |
|
I made cherry-pick on flourine: https://git.opendaylight.org/gerrit/c/aaa/+/83526 |