[AAA-228] Revisit aaa-cli-jar Created: 06/Jul/22  Updated: 29/Nov/22  Resolved: 29/Nov/22

Status: Resolved
Project: aaa
Component/s: None
Affects Version/s: None
Fix Version/s: 0.17.0

Type: Improvement Priority: Medium
Reporter: Robert Varga Assignee: Yaroslav Lastivka
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

aaa-cli-jar is shading H2 artifact with explicit package inclusions introduced without much of an explanation. This inclusion list was broken with AAA-221, indicating the solution is not maintainable.
It is understandable that we want the artifacts to be small, but that has to weighed against them being working without having to devise a completely new test suite.

Audit current H2 contents for what is being excluded and turn 'include' into 'exclude' with explicit justifications – for example we do not need JMX, as the CLI tool does not need it.

 Comments   
Comment by Yaroslav Lastivka [ 25/Nov/22 ]

All existing packages in org.h2:

Driver.class

JdbcDriverBackwardsCompat.class

api

bnf

command

compress

constraint

engine

expression

fulltext

index

jdbc

jdbcx

jmx

message

mode

mvstore

result

schema

security

server

store

table

tools

util

value

 

Comment by Yaroslav Lastivka [ 25/Nov/22 ]

Currently Included packages

<includes>
  <include>org/h2/Driver.class&amp;lt;/include>
  <include>org/h2/JdbcDriverBackwardsCompat.class&amp;lt;/include>
  <include>org/h2/api/**</include>
  <include>org/h2/command/**</include>
  <include>org/h2/compress/**</include>
  <include>org/h2/constraint/**</include>
  <include>org/h2/engine/**</include>
  <include>org/h2/expression/**</include>
  <include>org/h2/index/**</include>
  <include>org/h2/jdbc/**</include>
  <include>org/h2/message/**</include>
  <include>org/h2/mode/**</include>
  <include>org/h2/mvstore/**</include>
  <include>org/h2/pagestore/**</include>
  <include>org/h2/result/**</include>
  <include>org/h2/schema/**</include>
  <include>org/h2/security/**</include>
  <include>org/h2/store/**</include>
  <include>org/h2/table/**</include>
  <include>org/h2/upgrade/**</include>
  <include>org/h2/util/**</include>
  <include>org/h2/value/**</include>
</includes>
Comment by Yaroslav Lastivka [ 25/Nov/22 ]

List of excluded packages:

                  <excludes>
                    <exclude>org/h2/bnf/**</exclude>
                    <exclude>org/h2/jdbcx/**</exclude>
                    <exclude>org/h2/jmx/**</exclude>
                    <exclude>org/h2/server/**</exclude>
                  </excludes>
Comment by Ivan Hrasko [ 28/Nov/22 ]

The excluded packages should be: bnf, fulltext, jdbcx, jmx, server, tools.

Generated at Wed Feb 07 19:08:59 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.