[AAA-63] Build cycle between aaa - controller - netconf Created: 27/Aug/15 Updated: 21/Mar/19 Resolved: 03/Sep/15 |
|
| Status: | Resolved |
| Project: | aaa |
| Component/s: | General |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Thanh Ha (zxiiro) | Assignee: | Tomas Cere |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 4216 |
| Description |
|
There is now a build cycle between the 3 projects:
Need to investigate how to remove the cycle. I'm not sure which project to raise this against so starting with netconf first. [ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between 'Vertex {label='org.opendaylight.controller:features-netconf:0.4.0-Daily-v201508271823'}' and 'Vertex {label='org.opendaylight.aaa:features-aaa:0.3.0-Daily-v201508271823'}' introduces to cycle in the graph org.opendaylight.aaa:features-aaa:0.3.0-Daily-v201508271823 --> org.opendaylight.controller:features-netconf:0.4.0-Daily-v201508271823 --> org.opendaylight.aaa:features-aaa:0.3.0-Daily-v201508271823 @ ' and 'Vertex {label='org.opendaylight.aaa:features-aaa:0.3.0-Daily-v201508271823'}' introduces to cycle in the graph org.opendaylight.aaa:features-aaa:0.3.0-Daily-v201508271823 --> org.opendaylight.controller:features-netconf:0.4.0-Daily-v201508271823 --> org.opendaylight.aaa:features-aaa:0.3.0-Daily-v201508271823 -> [Help 1] |
| Comments |
| Comment by Thanh Ha (zxiiro) [ 27/Aug/15 ] |
|
I think the issue is aaa hasn't updated their dependencies to use the new netconf project's groupId. I'll try to get a working patch soon. |
| Comment by Thanh Ha (zxiiro) [ 27/Aug/15 ] |
|
Moving to aaa |
| Comment by Thanh Ha (zxiiro) [ 27/Aug/15 ] |
|
Proposed patch: https://git.opendaylight.org/gerrit/26110/ |
| Comment by Tony Tkacik [ 28/Aug/15 ] |
|
The cycle will fully be resolved once everyone migrates to new netconf groupIds |
| Comment by Thanh Ha (zxiiro) [ 28/Aug/15 ] |
|
I abandoned my patch since Tomas created another version which is a little more complete than my attempt: https://git.opendaylight.org/gerrit/26142/ The build issue still remains though. I think it has to do with build order for the single feature test. |
| Comment by Thanh Ha (zxiiro) [ 01/Sep/15 ] |
|
So with Ed's help we now have a new conclusion. If you look at the output of "mvn dependency:tree" you can see that there's a cyclic dependency being caused by a dependency features-netconf. [INFO] +- org.opendaylight.netconf:features-netconf:xml:features:1.0.0-SNAPSHOT:runtime So we think that the root cause is that when building features-aaa we depend on features-netconf which in turn depends on the previous version of features-aaa which is pulling in the out of date features.xml and causing the build issue we are seeing. We think that the cyclic dependency will need to be broken but I'm not sure where this should happen. |
| Comment by Tomas Cere [ 02/Sep/15 ] |
|
I broke the cycle with moving aaa-authn-odl-plugin to netconf as Robert suggested. |
| Comment by Thanh Ha (zxiiro) [ 03/Sep/15 ] |
|
(In reply to Tomas Cere from comment #7) Looks like the cycle is gone in the autorelease build now. There's a new aaa error but I will investigate it and open a different bug if necessary. Thanks. |