[AFFINITY-2] Please convert System.out.println usage to proper log statements Created: 15/Jan/14  Updated: 19/Oct/17  Resolved: 20/Jan/14

Status: Resolved
Project: affinity
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Improvement
Reporter: Ed Warnicke Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Mac OS
Platform: PC



 Description   

Please convert all usages of System.out.println to proper log statements:

ubdir affinity/
Running command: grep -rn System.out .
./affinity/api/src/main/java/org/opendaylight/affinity/affinity/AffinityGroup.java:98: System.out.println("Printing affinity group " + this.name);
./affinity/api/src/main/java/org/opendaylight/affinity/affinity/AffinityIdentifier.java:26: System.out.println(name);
./affinity/api/src/main/java/org/opendaylight/affinity/affinity/AffinityLink.java:84: System.out.println("Printing affinity attribute: " + attr.type);
./affinity/api/src/test/java/org/opendaylight/affinity/affinity/AffinityGroupTest.java:35: System.out.println(ret3);
./affinity/api/src/test/java/org/opendaylight/affinity/affinity/AffinityGroupTest.java:58: System.out.println("Affinity group size is " + ag1.size());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:50: System.out.println(ret3);
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:72: System.out.println("Affinity group size is " + ag1.size());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:111: System.out.println("affinity link " + al3.getName());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:115: System.out.println("flow with from=" + flow.getKey() + " to=" + flow.getValue());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:121: // System.out.println("Affinity group (as Hosts) = " + ag1.getName());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:125: // System.out.println("host = " + h.getNetworkAddressAsString());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:129: System.out.println("Affinity group (as Affinity Identifiers) = " + ag1.getName());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:137: System.out.println("Affinity link = " + al1.getName());
./affinity/implementation/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerImplTest.java:141: System.out.println("flow " + "from: " + flow.getKey().toString() + "to: " + flow.getValue().toString());
./affinity/integrationtest/src/test/java/org/opendaylight/affinity/affinity/internal/AffinityManagerIT.java:112: System.out.println(">>> " + b[i].getSymbolicName() + " " + stateToString(state));



 Comments   
Comment by Suchitra Raman [ 20/Jan/14 ]

I've checked in a change that uses logger for OSGi modules.
There are a few println statements in unit test code, which seems ok to me.
If this is not acceptable, I'll take care of the test code in a second commit.
Marking this as fixed. Please re-open if test code must be converted.

Generated at Wed Feb 07 19:09:09 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.