Operating System: All
Platform: All

This bug is cause by a AD-SAL dependency in alto-northbound and simple-alto. The dependency on AD-SAL is planned to be removed in next release, so we will just modify the pom file to depend on a stable release version of AD-SAL package to solve this problem for now.

https://git.opendaylight.org/gerrit/24152

According to Kai's comment, if the autorelease is using the snapshot repository, maven would not be able to find the packages with the 'lithium' release. I'm not sure if it is the case but if the fix doesn't work out I will find a better way to solve this problem.

(In reply to Shu Dong from comment #3)
> According to Kai's comment, if the autorelease is using the snapshot
> repository, maven would not be able to find the packages with the 'lithium'
> release. I'm not sure if it is the case but if the fix doesn't work out I
> will find a better way to solve this problem.

That's right, autorelease builds perform release type builds and thus does not depend on any opendaylight artifacts from the Internet or Nexus. All ODL artifacts must be resolveable and buildable from within the autorelease build itself. So I am -1 on the proposed change.

Since AD-SAL is being removed from Beryllium you must adapt alto to not use this outdated artifact.

(In reply to Thanh Ha from comment #4)
> (In reply to Shu Dong from comment #3)
> > According to Kai's comment, if the autorelease is using the snapshot
> > repository, maven would not be able to find the packages with the 'lithium'
> > release. I'm not sure if it is the case but if the fix doesn't work out I
> > will find a better way to solve this problem.
>
> That's right, autorelease builds perform release type builds and thus does
> not depend on any opendaylight artifacts from the Internet or Nexus. All ODL
> artifacts must be resolveable and buildable from within the autorelease
> build itself. So I am -1 on the proposed change.
>
> Since AD-SAL is being removed from Beryllium you must adapt alto to not use
> this outdated artifact.

Please review the latest fix: https://git.opendaylight.org/gerrit/24189

(In reply to Thanh Ha from comment #4)
> (In reply to Shu Dong from comment #3)
> > According to Kai's comment, if the autorelease is using the snapshot
> > repository, maven would not be able to find the packages with the 'lithium'
> > release. I'm not sure if it is the case but if the fix doesn't work out I
> > will find a better way to solve this problem.
>
> That's right, autorelease builds perform release type builds and thus does
> not depend on any opendaylight artifacts from the Internet or Nexus. All ODL
> artifacts must be resolveable and buildable from within the autorelease
> build itself. So I am -1 on the proposed change.
>
> Since AD-SAL is being removed from Beryllium you must adapt alto to not use
> this outdated artifact.

I noticed that you voted +1 on my latest fix. Thanks very much for your code review! So does it mean next we should merge the patch to master by ourselves to see if it works?

(In reply to Shu Dong from comment #6)
> I noticed that you voted +1 on my latest fix. Thanks very much for your code
> review! So does it mean next we should merge the patch to master by
> ourselves to see if it works?

Yes please do, I'm not a Java expert so I can't say if the fix is good but once you merge it we can kick off an autorelease build to see if it passes.

(In reply to Thanh Ha from comment #7)
> (In reply to Shu Dong from comment #6)
> > I noticed that you voted +1 on my latest fix. Thanks very much for your code
> > review! So does it mean next we should merge the patch to master by
> > ourselves to see if it works?
>
> Yes please do, I'm not a Java expert so I can't say if the fix is good but
> once you merge it we can kick off an autorelease build to see if it passes.

Thanks for your explanation. I have merged the fix into master. Please feel free to kick off a new autorelease build to check if it solves the problem. Thanks a lot!

(In reply to Thanh Ha from comment #7)
> (In reply to Shu Dong from comment #6)
> > I noticed that you voted +1 on my latest fix. Thanks very much for your code
> > review! So does it mean next we should merge the patch to master by
> > ourselves to see if it works?
>
> Yes please do, I'm not a Java expert so I can't say if the fix is good but
> once you merge it we can kick off an autorelease build to see if it passes.

I noticed that the ALTO was not enabled in the latest Jenkins autorelease build https://jenkins.opendaylight.org/releng/job/autorelease-daily-master/94/, do you know how to enable it so we could see if the fix works out? Thanks a lot!

(In reply to Shu Dong from comment #9)
> I noticed that the ALTO was not enabled in the latest Jenkins autorelease
> build
> https://jenkins.opendaylight.org/releng/job/autorelease-daily-master/94/, do
> you know how to enable it so we could see if the fix works out? Thanks a lot!

Sorry I didn't re-enable alto for the build before taking off for the weekend. I kicked off build #96 which should include alto this time.

simple-impl successfully built:

https://jenkins.opendaylight.org/releng/view/autorelease/job/autorelease-daily-master/96/org.opendaylight.alto$simple-impl/console

We're now failing on alto-northbuild. I'll open a separate bug for that.