[BGPCEP-1016] Do not use BindingReflections.findQName() for AFI/SAFI Created: 13/Dec/22  Updated: 23/Jun/23  Resolved: 23/Jun/23

Status: Resolved
Project: bgpcep
Component/s: BGP, BMP
Affects Version/s: None
Fix Version/s: 0.20.0

Type: Task Priority: Medium
Reporter: Robert Varga Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks MDSAL-781 Eliminate BindingReflections Confirmed
Epic Link: AOT friendliness

 Description   

We have following hits on BindingReflections use:

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/AbstractRIBSupport.java:172:            BindingReflections.findQName(afiClass.implementedInterface()),

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/AbstractRIBSupport.java:173:            BindingReflections.findQName(safiClass.implementedInterface())));

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:58:            BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:59:            BindingReflections.findQName(safi.implementedInterface())));

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:73:            BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bgp/rib-spi/src/main/java/org/opendaylight/protocol/bgp/rib/spi/RibSupportUtils.java:74:            BindingReflections.findQName(safi.implementedInterface())));   ./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:43:            BMP_AFI_QNAME, BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:44:            BMP_SAFI_QNAME, BindingReflections.findQName(safi.implementedInterface())));

./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:60:            afiQname, BindingReflections.findQName(afi.implementedInterface()),

./bgpcep/bmp/bmp-impl/src/main/java/org/opendaylight/protocol/bmp/impl/app/TablesUtil.java:61:            safiQname, BindingReflections.findQName(safi.implementedInterface())));

As we are moving away from using reflection, migrate these call sites to use mdsal-binding-dom-codec's IdentityCodec to translate these.


Generated at Wed Feb 07 19:14:47 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.