[BGPCEP-270] Flowspec route yang model bug Created: 24/Aug/15  Updated: 03/Mar/19  Resolved: 29/Oct/15

Status: Resolved
Project: bgpcep
Component/s: BGP
Affects Version/s: Bugzilla Migration
Fix Version/s: Bugzilla Migration

Type: Bug
Reporter: Iveta Halanova Assignee: Iveta Halanova
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Issue Links:
Blocks
is blocked by YANGTOOLS-488 Issue augmenting choice inside a list Resolved
is blocked by YANGTOOLS-510 ListItem nodes can't be wroten succes... Resolved
is blocked by YANGTOOLS-527 Write to datastore: route does not ha... Resolved
External issue ID: 4173
Priority: High

 Description   

Flowspec route should contain just one choice of type, not list of types.



 Comments   
Comment by Milos Fabian [ 24/Aug/15 ]

Proposed fix for lithium - needs to be verified
https://git.opendaylight.org/gerrit/#/c/25287/

Comment by Milos Fabian [ 02/Sep/15 ]

There is another issue in the model - extended communities in FS route attributes are not augmented with FS extensions

2015-08-31 14:47:48,261 | WARN | oupCloseable-3-1 | DefaultChannelPipeline | 88 - io.netty.common - 4.0.26.Final | An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalArgumentException
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2203)[64:com.google.guava:18.0.0]
at com.google.common.cache.LocalCache.get(LocalCache.java:3937)[64:com.google.guava:18.0.0]
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3941)[64:com.google.guava:18.0.0]
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4824)[64:com.google.guava:18.0.0]
at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4830)[64:com.google.guava:18.0.0]
at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCache.get(BindingNormalizedNodeCache.java:44)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.CachingNormalizedNodeSerializer.serialize(CachingNormalizedNodeSerializer.java:69)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.CachingNormalizedNodeSerializer.serialize(CachingNormalizedNodeSerializer.java:29)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.Attributes$StreamWriter.serialize(DataObjectSerializerPrototype.java)[93:org.opendaylight.bgpcep.bgp-parser-api:0.4.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry$DataObjectSerializerProxy.serialize(BindingNormalizedNodeCodecRegistry.java:295)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.CachingNormalizedNodeSerializer.serializeUsingStreamWriter(CachingNormalizedNodeSerializer.java:120)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.CachingNormalizedNodeSerializer.serialize(CachingNormalizedNodeSerializer.java:105)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.CachingNormalizedNodeCodec.serialize(CachingNormalizedNodeCodec.java:35)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.RIBSupportContextImpl.serializeAttributes(RIBSupportContextImpl.java:184)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.RIBSupportContextImpl.writeRoutes(RIBSupportContextImpl.java:136)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.TableContext.writeRoutes(TableContext.java:49)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.AdjRibInWriter.updateRoutes(AdjRibInWriter.java:235)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:123)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:67)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:217)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:53)[198:org.opendaylight.bgpcep.bgp-rib-impl:0.4.1.Lithium-SR1]
at org.opendaylight.protocol.framework.AbstractProtocolSession.channelRead0(AbstractProtocolSession.java:53)[100:org.opendaylight.controller.protocol-framework:0.6.1.Lithium-SR1]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:339)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:324)[99:io.netty.transport:4.0.26.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:242)[153:io.netty.codec:4.0.26.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:339)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:324)[99:io.netty.transport:4.0.26.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:242)[153:io.netty.codec:4.0.26.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:339)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:324)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:847)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:511)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)[99:io.netty.transport:4.0.26.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)[99:io.netty.transport:4.0.26.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111)[88:io.netty.common:4.0.26.Final]
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)[88:io.netty.common:4.0.26.Final]
at java.lang.Thread.run(Thread.java:724)[:1.7.0_25]
Caused by: java.lang.IllegalArgumentException
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:108)[64:com.google.guava:18.0.0]
at org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNormalizedNodeStreamWriter.startUnkeyedListItem(ImmutableNormalizedNodeStreamWriter.java:184)[103:org.opendaylight.yangtools.yang-data-impl:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.BindingToNormalizedStreamWriter.startUnkeyedListItem(BindingToNormalizedStreamWriter.java:179)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.ForwardingBindingStreamEventWriter.startUnkeyedListItem(ForwardingBindingStreamEventWriter.java:57)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.attributes.ExtendedCommunities$StreamWriter.serialize(DataObjectSerializerPrototype.java)[93:org.opendaylight.bgpcep.bgp-parser-api:0.4.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry$DataObjectSerializerProxy.serialize(BindingNormalizedNodeCodecRegistry.java:295)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.CachingNormalizedNodeSerializer.serializeUsingStreamWriter(CachingNormalizedNodeSerializer.java:120)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCache.load(BindingNormalizedNodeCache.java:32)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCache.load(BindingNormalizedNodeCache.java:17)[124:org.opendaylight.yangtools.binding-data-codec:0.7.1.Lithium-SR1]
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3527)[64:com.google.guava:18.0.0]
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2319)[64:com.google.guava:18.0.0]
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2282)[64:com.google.guava:18.0.0]
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2197)[64:com.google.guava:18.0.0]

Comment by Iveta Halanova [ 28/Sep/15 ]

https://git.opendaylight.org/gerrit/#/c/27505/

Comment by Iveta Halanova [ 02/Oct/15 ]

https://git.opendaylight.org/gerrit/27581

Comment by Iveta Halanova [ 29/Oct/15 ]

https://git.opendaylight.org/gerrit/27581

Generated at Wed Feb 07 19:12:32 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.