[BGPCEP-384] Dead letters encountered in a basic 1node BGP test Created: 01/Feb/16  Updated: 03/Mar/19  Resolved: 02/Mar/16

Status: Resolved
Project: bgpcep
Component/s: BGP
Affects Version/s: Bugzilla Migration
Fix Version/s: Bugzilla Migration

Type: Bug
Reporter: Vratko Polak Assignee: Milos Fabian
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 5171
Priority: Low

 Description   

This Beryllium bug may have a cause common with other bugs, but the symptom is different.

When using data with rib-instance (as specified in BGPCEP-244) in basic BGP suite (running after tcpmd5 suite but before other bgp suites), ODL disconnects the newly configured peer. Sandbox link [0].
The subsequent test cases within the suite (when ODL initiates and peer listens) pass. This may be a heisenbug.

[0] https://jenkins.opendaylight.org/sandbox/job/bgpcep-csit-1node-userfeatures-only-beryllium/8/robot/bgpcep-userfeatures.txt/Cases/

Part of karaf.log:

2016-02-01 14:35:10,370 | INFO | h for user karaf | command | 222 - org.apache.karaf.log.command - 3.0.3 | ROBOT MESSAGE: Starting test Start_Talking_BGP_speaker
2016-02-01 14:35:10,517 | INFO | oupCloseable-6-4 | StrictBGPPeerRegistry | 305 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.SNAPSHOT | BGP Open message session parameters differ, session still accepted.
2016-02-01 14:35:10,521 | INFO | oupCloseable-6-4 | BGPSessionImpl | 305 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.SNAPSHOT | BGP HoldTimer new value: 180
2016-02-01 14:35:10,528 | INFO | oupCloseable-6-4 | BGPPeer | 305 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.SNAPSHOT | Session with peer 10.30.32.191 went up with tables: [BgpTableTypeImpl [getAfi()=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.Ipv4AddressFamily, getSafi()=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.UnicastSubsequentAddressFamily]]
2016-02-01 14:35:10,540 | INFO | oupCloseable-6-4 | AbstractBGPSessionNegotiator | 305 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.SNAPSHOT | BGP Session with peer [id: 0xe5fb9375, /10.30.32.191:17900 => /10.30.32.188:1790] established successfully.
2016-02-01 14:35:10,737 | INFO | oupCloseable-6-4 | BGPSynchronization | 305 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.SNAPSHOT | BGP Synchronization finished for table TablesKey [_afi=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.Ipv4AddressFamily, _safi=class org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.UnicastSubsequentAddressFamily]
2016-02-01 14:35:11,098 | INFO | ult-dispatcher-3 | rovider$RemoteDeadLetterActorRef | 129 - com.typesafe.akka.slf4j - 2.3.14 | Message [org.opendaylight.controller.cluster.datastore.messages.CloseDataTreeChangeListenerRegistrationReply] from Actorakka://opendaylight-cluster-data/user/shardmanager-operational/member-1-shard-default-operational/$k#-221548343 to Actor[akka://opendaylight-cluster-data/deadLetters] was not delivered. [1] dead letters encountered. This logging can be turned off or adjusted with configuration settings 'akka.log-dead-letters' and 'akka.log-dead-letters-during-shutdown'.
2016-02-01 14:35:11,100 | INFO | entLoopGroup-2-2 | BGPSessionImpl | 305 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.0.SNAPSHOT | Closing session: BGPSessionImpl

{channel=[id: 0xe5fb9375, /10.30.32.191:17900 => /10.30.32.188:1790], state=UP}

 Comments   
Comment by Vratko Polak [ 01/Feb/16 ]

Note that this only happens when the correct "rib-instance" data (according to BGPCEP-244) is used.
If the "rib" is used instead, test cases pass [0], but karaf.log complains:

2016-02-01 14:51:05,956 | ERROR | lt-dispatcher-34 | DataTreeChangeListenerActor | 143 - org.opendaylight.controller.sal-distributed-datastore - 1.3.0.SNAPSHOT | Error notifying listener org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataTreeChangeListenerAdapter@48d31e68
com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalArgumentException: Supplied QName (urn:opendaylight:params:xml:ns:yang:controller:bgp:rib:impl?revision=2013-04-09)rib is not a valid identity

[0] https://jenkins.opendaylight.org/sandbox/job/bgpcep-csit-1node-userfeatures-only-beryllium/9/robot/bgpcep-userfeatures.txt/Cases/

Comment by Milos Fabian [ 04/Feb/16 ]

The logged message about the "dead letters" seems to be harmless for the BGP functionality. Anyway, we should find out if the root cause is in the BGP code or the problem is somewhere else. Putting lower priority on this one.

Comment by Vratko Polak [ 02/Mar/16 ]

The symptoms are no longer visible on recent Beryllium builds.

Generated at Wed Feb 07 21:16:52 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.