[BGPCEP-405] BGP-LS topology provider NPE Created: 07/Mar/16  Updated: 03/Mar/19  Resolved: 31/Mar/16

Status: Verified
Project: bgpcep
Component/s: BGP
Affects Version/s: Bugzilla Migration
Fix Version/s: Bugzilla Migration 1.0

Type: Bug
Reporter: Milos Fabian Assignee: Milos Fabian
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


Attachments: File bgp-ls-li-bug.xml    
Issue Links:
Duplicate
is duplicated by BGPCEP-411 iinkstate topology incorrect in prese... Resolved
External issue ID: 5467

 Description   

NPE appears in iBGP + eBGP BGP-LS neighbors connected to ODL.

2016-03-04 06:33:48,946 | WARN | lt-dispatcher-16 | AbstractTopologyBuilder | 202 - org.opendaylight.bgpcep.bgp-topology-provider - 0.4.4.Lithium-SR4 | Data change org.opendaylight.controller.md.sal.binding.impl.LazyDataTreeModification@583244be was not completely propagated to listener org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder@4c3f432e, aborting
java.lang.NullPointerException
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.isisNodeAttributes(LinkstateTopologyBuilder.java:625)[202:org.opendaylight.bgpcep.bgp-topology-provider:0.4.4.Lithium-SR4]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.augmentProtocolId(LinkstateTopologyBuilder.java:687)[202:org.opendaylight.bgpcep.bgp-topology-provider:0.4.4.Lithium-SR4]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createNode(LinkstateTopologyBuilder.java:733)[202:org.opendaylight.bgpcep.bgp-topology-provider:0.4.4.Lithium-SR4]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:848)[202:org.opendaylight.bgpcep.bgp-topology-provider:0.4.4.Lithium-SR4]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:121)[202:org.opendaylight.bgpcep.bgp-topology-provider:0.4.4.Lithium-SR4]
at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onDataTreeChanged(AbstractTopologyBuilder.java:152)[202:org.opendaylight.bgpcep.bgp-topology-provider:0.4.4.Lithium-SR4]
at org.opendaylight.controller.md.sal.binding.impl.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:41)[170:org.opendaylight.controller.sal-binding-broker-impl:1.2.4.Lithium-SR4]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:53)[192:org.opendaylight.controller.sal-distributed-datastore:1.2.4.Lithium-SR4]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:37)[192:org.opendaylight.controller.sal-distributed-datastore:1.2.4.Lithium-SR4]
at org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor.onReceive(AbstractUntypedActor.java:34)[184:org.opendaylight.controller.sal-clustering-commons:1.2.4.Lithium-SR4]
at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:167)[177:com.typesafe.akka.actor:2.3.10]
at akka.actor.Actor$class.aroundReceive(Actor.scala:467)[177:com.typesafe.akka.actor:2.3.10]
at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:97)[177:com.typesafe.akka.actor:2.3.10]
at akka.actor.ActorCell.receiveMessage(ActorCell.scala:516)[177:com.typesafe.akka.actor:2.3.10]
at akka.actor.ActorCell.invoke(ActorCell.scala:487)[177:com.typesafe.akka.actor:2.3.10]
at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:254)[177:com.typesafe.akka.actor:2.3.10]
at akka.dispatch.Mailbox.run(Mailbox.scala:221)[177:com.typesafe.akka.actor:2.3.10]
at akka.dispatch.Mailbox.exec(Mailbox.scala:231)[177:com.typesafe.akka.actor:2.3.10]
at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)[174:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)[174:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)[174:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]
at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)[174:org.scala-lang.scala-library:2.10.4.v20140209-180020-VFINAL-b66a39653b]

Note: Logs above comes from Lithium, but the same issue also appears in Beryllium release
Also see the attached topology.



 Comments   
Comment by Milos Fabian [ 07/Mar/16 ]

Attachment bgp-ls-li-bug.xml has been added with description: BGP-LS topology

Comment by Vratko Polak [ 16/Mar/16 ]

Current Beryllium snapshot:
Peer sends:
OPEN message encoded: 0xffffffffffffffffffffffffffffffff00350104fbf000b40a1e205c1802060104000100010206010440040047020641040000fbf0
(then keepalive),
UPDATE message encoded: 0xffffffffffffffffffffffffffffffff003c0200000025800e2240044704c00002010000050015070000000000000001010203040001000105060708
(then end-of-rib).

and karaf.log contains:
2016-03-16 12:49:46,543 | INFO | oupCloseable-6-2 | AbstractBGPSessionNegotiator | 268 - org.opendaylight.bgpcep.bgp-rib-impl - 0.5.1.SNAPSHOT | BGP Session with peer [id: 0xf0b70976, /10.30.32.92:17900 => /10.30.32.24:1790] established successfully.
2016-03-16 12:49:46,757 | WARN | oupCloseable-6-2 | LinkstateNlriParser | 266 - org.opendaylight.bgpcep.bgp-linkstate - 0.5.1.SNAPSHOT | Unknown Object Type.
2016-03-16 12:49:46,757 | WARN | oupCloseable-6-2 | LinkstateNlriParser | 266 - org.opendaylight.bgpcep.bgp-linkstate - 0.5.1.SNAPSHOT | Unknown NLRI Type.

Comment by Milos Fabian [ 18/Mar/16 ]

https://git.opendaylight.org/gerrit/#/c/36431/

Comment by Peter Gubka [ 31/Mar/16 ]

verified checking karaf log in https://jenkins.opendaylight.org/releng/view/bgpcep/job/bgpcep-csit-1node-userfeatures-only-beryllium/1218/

Generated at Wed Feb 07 19:12:58 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.