[BGPCEP-423] PCRpt message with vendor specific object throws exception Created: 28/Mar/16  Updated: 03/Mar/19  Resolved: 26/Jul/16

Status: Resolved
Project: bgpcep
Component/s: PCEP
Affects Version/s: Bugzilla Migration
Fix Version/s: Bugzilla Migration

Type: Bug
Reporter: swapna kuppani Assignee: Milos Fabian
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 5610

 Description   

If ODL receives PCRpt message with vendor specific object, ODL throws exception and continue processing the next.

In AbstractMessageParser

if (VendorInformationUtil.isVendorInformationObject(objClass, objType)) {
Preconditions.checkState(this.viRegistry != null);

RFC Point:

“If the PCE does not understand an object with the P flag set or

understands the object but decides to ignore the object, the entire

PCEP message MUST be rejected and the PCE MUST send a PCErr message

with Error-Type="Unknown Object" or "Not supported Object" along with

the corresponding RP object. Note that if a PCReq includes multiple

requests, only requests for which an object with the P flag set is

unknown/unrecognized MUST be rejected.”

According to the above instead of throwing an exception, need to send the above error message to the peer.



 Comments   
Comment by Milos Fabian [ 05/Apr/16 ]

stable/beryllium: https://git.opendaylight.org/gerrit/#/c/37145/

Comment by Milos Fabian [ 19/Jul/16 ]

TODO: port the fix to master branch

Comment by Milos Fabian [ 26/Jul/16 ]

master: https://git.opendaylight.org/gerrit/#/c/42584/

Generated at Wed Feb 07 19:13:01 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.